Fix test for keda cpu

[mwaykole]

test fix for keda cpu

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes

  • Improved reliability of threshold comparisons and pod count verification in KEDA scaling tests.
  • Fixed parameter naming and usage inconsistencies in test fixtures.

• New Features

  • Enhanced KEDA scaling tests to generate inference load and validate scaling behavior.
  • Added runtime patching for authentication in specific test scenarios.

• Refactor

  • Updated function and fixture signatures for improved clarity and consistency.
  • Simplified and clarified test metric queries and configuration handling.

Walkthrough

This update modifies KEDA autoscaling test infrastructure and utilities. It updates function signatures to include model name and namespace, adjusts test logic for metric queries and thresholds, enhances test patching and load generation, and changes resource retrieval and verification logic to improve test reliability and clarity.

Changes

Cohort / File(s)	Change Summary
KEDA Test Fixtures and Utilities tests/model_serving/model_server/keda/conftest.py, tests/model_serving/model_server/utils.py	Updated fixture and utility function signatures to include model name and namespace; changed key access patterns; updated assertion logic for threshold comparison; improved pod count verification logic to raise errors only on timeout.
KEDA Scaling Test Suite tests/model_serving/model_server/keda/test_isvc_keda_scaling_cpu.py	Enhanced test logic: simplified metrics query, lowered threshold, added runtime patching for authentication, generated concurrent inference load, improved metric validation, and clarified pod count verification with docstrings.
KEDA Infra Utility utilities/infra.py	Modified get_isvc_keda_scaledobject to return a list containing the ScaledObject resource instead of the resource directly, maintaining exception behavior when not found.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15–20 minutes

Possibly related PRs

• feat: add keda scaling tests #479: Introduced KEDA scaling test infrastructure and utilities, directly relating to the fixture and utility updates in this PR.

Suggested labels

lgtm-by-mwaykole

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a4afb16 and 5013e0b.

📒 Files selected for processing (4)

• tests/model_serving/model_server/keda/conftest.py (5 hunks)
• tests/model_serving/model_server/keda/test_isvc_keda_scaling_cpu.py (6 hunks)
• tests/model_serving/model_server/utils.py (2 hunks)
• utilities/infra.py (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

The following are automatically added/executed:

• PR size label.
• Run pre-commit
• Run tox
• Add PR author as the PR assignee
• Build image based on the PR

Available user actions:

• To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
• To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
• To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
  lgtm label removed on each new commit push.
• To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
  verified label removed on each new commit push.
• To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
  and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
• To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
  pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.

Supported labels

{'/wip', '/lgtm', '/hold', '/cherry-pick', '/verified', '/build-push-pr-image'}

[pierDipi]

/lgtm
/approve

[github-actions]

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.