Skip to content

feat(openshift-python-wrapper): bump to the latest release#510

Closed
jstourac wants to merge 1 commit intoopendatahub-io:mainfrom
jstourac:bumpOcpPythonWrapper
Closed

feat(openshift-python-wrapper): bump to the latest release#510
jstourac wants to merge 1 commit intoopendatahub-io:mainfrom
jstourac:bumpOcpPythonWrapper

Conversation

@jstourac
Copy link
Copy Markdown
Member

@jstourac jstourac commented Aug 11, 2025

https://github.com/RedHatQE/openshift-python-wrapper/releases/tag/v11.0.85

Description

How Has This Been Tested?

Ran only workbench test against my cluster:

OC_BINARY_PATH=/home/jstourac/Downloads/openshift-client-linux/oc uv run pytest tests/workbenches/notebook-controller/test_spawning.py -v -s

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jstourac jstourac self-assigned this Aug 11, 2025
@jstourac jstourac requested a review from a team as a code owner August 11, 2025 12:12
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 11, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Upgraded the underlying OpenShift integration library to a newer version. Users may see improved reliability and compatibility when interacting with OpenShift resources. No feature changes to the UI/CLI, but background improvements may reduce edge-case failures and improve performance during cluster operations. No action is required from users; the update is included by default.

Walkthrough

Updated the openshift-python-wrapper dependency in pyproject.toml from 11.0.57 to 11.0.85. No other files, configuration, public APIs, or exported entities were changed.

Changes

Cohort / File(s) Summary of Changes
Dependency version bump
pyproject.toml
Bumped openshift-python-wrapper version constraint from 11.0.57 to 11.0.85. No other dependency or config changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a6c9da1 and 5d59cbc.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/wip', '/verified', '/build-push-pr-image', '/lgtm', '/cherry-pick', '/hold'}

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
pyproject.toml (1)

65-65: Constrain the upper bound to avoid accidental major upgrades.

Using >= may pull 12.x later with breaking changes. Recommend bounding to the current major.

Apply this diff:

-    "openshift-python-wrapper>=11.0.85",
+    "openshift-python-wrapper>=11.0.85,<12.0.0",
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between afa014d and a6c9da1.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
🔇 Additional comments (1)
pyproject.toml (1)

65-65: openshift-python-wrapper v11.0.85 compatibility confirmed

  • PyPI metadata requires_python: “>=3.10” ⇒ Python 3.13 is fully supported
  • No “deprec”, “remove” or “breaking” notes found in the v11.0.85 release description
  • All existing ocp_resources imports remain valid under this version

No further action required.

@jstourac jstourac force-pushed the bumpOcpPythonWrapper branch from a6c9da1 to 5d59cbc Compare August 11, 2025 12:27
@jstourac jstourac changed the title feat(openshift-python-wrapper): bump to latest release feat(openshift-python-wrapper): bump to the latest release Aug 11, 2025
@jstourac
Copy link
Copy Markdown
Member Author

Rebased to avoid merge conflict.

Copy link
Copy Markdown
Collaborator

@dbasunag dbasunag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed anymore. #505 picked the updated wrapper already.

@jstourac
Copy link
Copy Markdown
Member Author

Closing based on the discussion on Slack.

@jstourac jstourac closed this Aug 11, 2025
@jstourac jstourac deleted the bumpOcpPythonWrapper branch August 11, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants