Conversation
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/build-push-pr-image', '/hold', '/verified', '/lgtm', '/cherry-pick', '/wip'} |
📝 WalkthroughWalkthroughUpdated Renovate configuration in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
renovate.json (5)
3-3: Remove redundant dependencyDashboardApproval configurationYou enabled dependencyDashboardApproval both via root key and via preset. Keep one for clarity and to avoid future drift.
Option A — keep the preset, remove the root key:
- "dependencyDashboardApproval": true,Option B — keep the root key, drop the preset:
"extends": [ - "config:recommended", - ":dependencyDashboardApproval", + "config:recommended", ":maintainLockFilesWeekly", ":prHourlyLimitNone" ],Also applies to: 5-6
18-23: Broaden file match and enrich rule for minor/patch Python updatesIf you have Python projects in subdirectories, the current matchFileNames will miss them. Also, consider adding labels and (optionally) automerge for low-risk updates.
Suggested update:
- "matchFileNames": ["pyproject.toml"], + "matchFileNames": ["**/pyproject.toml"], "schedule": ["before 7am on monday"], - "prPriority": 7 + "prPriority": 7, + "labels": ["dependencies", "python", "minor-or-patch"] + // Optionally, if your CI is reliable for these updates: + // "automerge": true, + // "automergeType": "pr"If the repo only has a single pyproject.toml at root, keeping the current pattern is fine. Otherwise, prefer the glob.
24-30: Disambiguate major vs minor/patch grouping and add labelsBoth rules use the same groupName, which can be confusing in the dashboard. Make the major group explicit and label it for triage.
- "groupName": "Python dependencies", + "groupName": "Python dependencies (major)", "matchUpdateTypes": ["major"], - "matchFileNames": ["pyproject.toml"], + "matchFileNames": ["**/pyproject.toml"], "schedule": ["after 7pm on wednesday"], - "prPriority": 10 + "prPriority": 10, + "labels": ["dependencies", "python", "major"]
31-37: Simplify Actions rule; file match is redundant and add labelsThe github-actions manager inherently targets .github/workflows; specifying file globs is usually unnecessary. Add labels for easier filtering.
- "groupName": "GitHub Actions", - "matchManagers": ["github-actions"], - "matchFileNames": [".github/workflows/**"], - "schedule": ["before 6am on tuesday"], - "prPriority": 5 + "groupName": "GitHub Actions", + "matchManagers": ["github-actions"], + "schedule": ["before 6am on tuesday"], + "prPriority": 5, + "labels": ["dependencies", "github-actions"]
18-23: Set timezone to make schedules predictableYour schedules (“before 7am on monday”, etc.) default to UTC unless you set a timezone. If you intend local time, add a root-level timezone.
Add at the root of renovate.json (outside the shown ranges):
{ ... "timezone": "Etc/UTC" // or e.g. "America/New_York" / "Europe/Berlin" }Also applies to: 24-30, 31-37
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
renovate.json(2 hunks)
🔇 Additional comments (1)
renovate.json (1)
15-15: Keep “recreateWhen” as-is (supported in current Renovate versions)
- “recreateWhen” is a valid and documented option in Renovate ≥ 39.82.1, with two values:
• always – recreate PRs even if an identical one was closed previously
• never – do not recreate once closed (your current setting)- Older Renovate versions (≤ 37.235.5) will error on this field; if you see “Invalid configuration option: recreateWhen,” simply upgrade Renovate.
- No change needed in renovate.json (line 15) unless you deliberately want to switch to
"rebaseWhen": "behind-base-branch"for a different update strategy.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
renovate.json (2)
4-5: Preset swap to dependencyDashboardApproval changes workflow; and lockfile maintenance may now be defined twice
- Using ":dependencyDashboardApproval" requires manual approval in the Dependency Dashboard before any PRs are created. Confirm this is intended, otherwise Renovate may appear “silent” until approvals are given.
- With ":maintainLockFilesWeekly" in extends and an explicit "lockFileMaintenance": { "enabled": true } block elsewhere, you may be configuring the same feature twice. Prefer a single source of truth (either keep the preset or the explicit block) to avoid confusion.
Do you want me to collapse the duplicated lockfile maintenance config into one place?
14-15: Reassess recreateWhen=never; timezone LGTM
- "recreateWhen": "never" can leave PR branches stale if Renovate determines recreation would be beneficial (e.g., config changes, certain errors). The common default is "auto", which recreates only when necessary. Consider reverting to default or setting "auto" to reduce stuck PRs.
- "timezone": "America/New_York" looks valid for schedule evaluation.
Apply this diff if you want the safer default behavior:
- "recreateWhen": "never", + "recreateWhen": "auto",Please confirm if there’s a specific reason for forbidding recreation so we can document it in the config comments.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
renovate.json(2 hunks)
🔇 Additional comments (2)
renovate.json (2)
18-23: No additional Python dependency files detected; rule is sufficient
I verified that the repo only containspyproject.toml(nopoetry.lock,requirements*.txt, orPipfilefiles), so the existingmatchFileNamesentry already covers all Python manifests. The schedule remains valid if you intend to restrict updates to before 7 AM on Mondays.• File: renovate.json (lines 18–23) – no changes required.
24-30: Expand Python major rule coverage & confirm PR priorityThe current “Python dependencies (major)” rule only matches
pyproject.tomland uses a higherprPriority(10) than your minor/patch group (7). To ensure majors from lockfiles or requirements are grouped and to clarify priority intent:• Broaden the file-match to include any lockfiles or requirement files you use (e.g.
poetry.lock,requirements*.txt,Pipfile,Pipfile.lock).
• Decide if major upgrades truly deserve a higher PR priority than minor/patch—if so, note this policy; otherwise, lowerprPrioritybelow 7.Suggested diff:
{ "groupName": "Python dependencies (major)", "matchUpdateTypes": ["major"], - "matchFileNames": ["pyproject.toml"], + "matchFileNames": [ + "pyproject.toml", + "poetry.lock", + "requirements*.txt", + "Pipfile", + "Pipfile.lock" + ], "schedule": ["after 7pm on thursday"], - "prPriority": 10 + "prPriority": 4 },Please confirm if you’d like to widen the file patterns and/or keep majors at priority 10 so we can update the config or add a comment explaining your policy.
|
Status of building tag latest: failure. |
3 participants
Description
How Has This Been Tested?
Merge criteria:
Summary by CodeRabbit