Change to Fedora42 image by dbasunag · Pull Request #521 · opendatahub-io/opendatahub-tests

dbasunag · 2025-08-13T15:37:37Z

Description

How Has This Been Tested?

Merge criteria:

The commits are squashed in a cohesive manner and have meaningful messages.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

Chores
- Switched container base to Fedora to improve platform compatibility.
- Ensured Python 3.13 and pip are preinstalled in the image.
- Included common CLI utilities (SSH, curl, GNUPG, wget, vim, rsync, openssl) and grpcurl for tooling support.
- Cleaned package caches to reduce image size.
- Maintained existing runtime behavior and entrypoint; no functional changes for end-users.

coderabbitai · 2025-08-13T15:37:43Z

📝 Walkthrough

Walkthrough

Dockerfile now uses fedora:42 instead of python:3.13, switching provisioning from apt to dnf. It installs Python 3.13 (and pip) and various utilities via dnf, updates cleanup commands, and retains grpcurl install. Minor formatting changes; remaining build steps and behavior stay the same.

Changes

Cohort / File(s)	Summary of changes
Container build system `Dockerfile`	Switched base image to `fedora:42`; replaced apt with dnf for updates and installs (including python3.13 and python3.13-pip, ssh, gnupg, curl, gpg, wget, vim, httpd-tools, rsync, openssl, openssl-devel); updated cleanup to dnf equivalents; retained grpcurl install; minor whitespace adjustment; other steps unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-08-13T15:38:20Z

The following are automatically added/executed:

PR size label.
Run pre-commit
Run tox
Add PR author as the PR assignee
Build image based on the PR

Available user actions:

To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
lgtm label removed on each new commit push.
To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
verified label removed on each new commit push.
To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.

Supported labels

{'/wip', '/hold', '/verified', '/lgtm', '/cherry-pick', '/build-push-pr-image'}

dbasunag · 2025-08-13T15:39:19Z

/build-push-pr-image

github-actions · 2025-08-13T15:41:44Z

Status of building tag pr-521: success.
Status of pushing tag pr-521 to image registry: success.

fege

/lgtm

dbasunag · 2025-08-13T17:21:32Z

/build-push-pr-image

github-actions · 2025-08-13T17:23:10Z

Status of building tag pr-521: success.
Status of pushing tag pr-521 to image registry: success.

coderabbitai

Actionable comments posted: 3

🧹 Nitpick comments (2)

Dockerfile (2)
1-1: Prefer Fedora’s canonical registry image

For supply chain clarity and fresher metadata, consider pulling Fedora images from registry.fedoraproject.org.
-FROM fedora:42
+FROM registry.fedoraproject.org/fedora:42
6-6: Align UV_PYTHON with Fedora packaging

If Fedora 42’s default python3 is already 3.13, you can avoid version-specific package names and point uv to python3. This prevents breakage when Fedora revs Python.
-ENV UV_PYTHON=python3.13
+ENV UV_PYTHON=/usr/bin/python3
And ensure dnf installs python3 and python3-pip (see earlier comment).

Also applies to: 14-16

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 83f6a9a and a792655.

📒 Files selected for processing (1)

Dockerfile (2 hunks)

🔇 Additional comments (1)

Dockerfile (1)

25-26: Sanity-check uv inside the Docker image
The host-side check didn’t validate the image itself (since uv isn’t installed on your machine). Please verify in the built container:

• Build the image:
docker build -t uv-test .
• Confirm uv, Python, and PATH:
docker run --rm uv-test uv --version \
  && python3 --version \
  && which uv
• Test the sync step and entrypoint:
docker run --rm uv-test uv run --version
If UV_NO_SYNC=1 is blocking the sync, either unset it for that step:
RUN UV_NO_SYNC=0 uv sync
or remove the ENV UV_NO_SYNC=1 line if it isn’t needed.

sheltoncyril

/lgtm

github-actions · 2025-08-13T18:13:41Z

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

jstourac · 2025-08-14T11:49:13Z

@dbasunag My understanding is that this has to be backported to make the CI job pass e.g. in this PR #523. Is there any plan to backport?

(cherry picked from commit 69dc0d3)

* change(python3.13): move to Python 3.13 * Change to Fedora42 image (#521) (cherry picked from commit 69dc0d3) --------- Co-authored-by: Debarati Basu-Nag <dbasunag@redhat.com>

github-actions bot assigned dbasunag Aug 13, 2025

github-actions bot added the size/xs label Aug 13, 2025

rhods-ci-bot added the build-push-pr-image label Aug 13, 2025

adolfo-ab previously approved these changes Aug 13, 2025

View reviewed changes

rhods-ci-bot added the lgtm-by-adolfo-ab label Aug 13, 2025

fege previously approved these changes Aug 13, 2025

View reviewed changes

rhods-ci-bot added the lgtm-by-fege label Aug 13, 2025

Change to Fedora42 image

a792655

dbasunag dismissed stale reviews from fege and adolfo-ab via a792655 August 13, 2025 17:20

dbasunag force-pushed the fedora42 branch from c909137 to a792655 Compare August 13, 2025 17:20

rhods-ci-bot removed lgtm-by-adolfo-ab lgtm-by-fege labels Aug 13, 2025

dbasunag marked this pull request as ready for review August 13, 2025 17:21

dbasunag requested a review from a team as a code owner August 13, 2025 17:21

coderabbitai bot reviewed Aug 13, 2025

View reviewed changes

Comment thread Dockerfile

Comment thread Dockerfile

Comment thread Dockerfile

rhods-ci-bot added the commented-by-dbasunag label Aug 13, 2025

sheltoncyril approved these changes Aug 13, 2025

View reviewed changes

rhods-ci-bot added the lgtm-by-sheltoncyril label Aug 13, 2025

dbasunag mentioned this pull request Aug 13, 2025

update Dockerfile #520

Closed

3 tasks

dbasunag merged commit 69dc0d3 into opendatahub-io:main Aug 13, 2025
12 checks passed

dbasunag deleted the fedora42 branch August 13, 2025 18:12

jstourac mentioned this pull request Aug 14, 2025

[2.23] fix(workbenches): the way we check internal image registry state #523

Merged

3 tasks

rhods-ci-bot added the commented-by-jstourac label Aug 14, 2025

This was referenced Aug 14, 2025

[2.22] fix(workbenches): the way we check internal image registry state #524

Merged

[2.23] Change to Fedora42 image #526

Merged

jstourac pushed a commit to jstourac/opendatahub-tests that referenced this pull request Aug 21, 2025

Change to Fedora42 image (opendatahub-io#521)

f458254

(cherry picked from commit 69dc0d3)

jstourac mentioned this pull request Aug 21, 2025

[2.22] Backport img build fix and move to Python 3.13 #540

Merged

3 tasks

Conversation

dbasunag commented Aug 13, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Merge criteria:

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

Status, Documentation and Community

Uh oh!

github-actions bot commented Aug 13, 2025

Uh oh!

dbasunag commented Aug 13, 2025

Uh oh!

github-actions bot commented Aug 13, 2025

Uh oh!

fege left a comment

Choose a reason for hiding this comment

Uh oh!

dbasunag commented Aug 13, 2025

Uh oh!

github-actions bot commented Aug 13, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sheltoncyril left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 13, 2025

Uh oh!

jstourac commented Aug 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dbasunag commented Aug 13, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 13, 2025 •

edited

Loading