fix: add no-op for --collect-must-gather in older versions#541
Closed
adolfo-ab wants to merge 11 commits intoopendatahub-io:mainfrom
Closed
fix: add no-op for --collect-must-gather in older versions#541adolfo-ab wants to merge 11 commits intoopendatahub-io:mainfrom
adolfo-ab wants to merge 11 commits intoopendatahub-io:mainfrom
Conversation
…ahub-io#173) (opendatahub-io#175) * Create size-labeler.yml * Delete .github/workflows/size-labeler.yml * model mesh - add auth tests * xx * feat: add deployment mode markers for upgrade tests
…o#387)" (opendatahub-io#388) This reverts commit 5966e5b.
Signed-off-by: lugi0 <lgiorgi@redhat.com>
…atahub-io#439) * fix: lmeval test format * fix: add securityContext to minio container
adolfo-ab
requested review from
a team,
Raghul-M,
dbasunag,
fege,
lugi0,
mwaykole and
sheltoncyril
as code owners
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughUpdates GitHub workflows (token use, welcome-assignee behavior, new build/push-on-merge pipeline), adjusts README/docs, and extends workflow scripts to assign PR authors. Test infrastructure gains upgrade-mode gating, new pytest options, and Model Registry test refactor with new utilities and upgrade tests. Minor fixtures and security context tweaks included. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor GitHub
participant Workflow as Build/Push On PR Merge
participant Quay as Quay Registry
participant PR as Pull Request
GitHub->>Workflow: pull_request_target (closed)
alt PR is merged
Workflow->>Workflow: Determine TAG (main -> latest else base ref)
Workflow->>Workflow: Build image (Buildah)
Workflow->>Quay: Push image (image:tag)
Workflow->>PR: Comment build/push status
else Not merged
Note over Workflow: Job skipped (if condition)
end
sequenceDiagram
autonumber
actor GH as GitHub
participant Job as add-welcome-comment-set-assignee
participant API as GitHub API
GH->>Job: PR opened
Job->>API: Post welcome comment
Job->>API: Assign PR author as assignee
alt UnknownObjectException
Job->>Job: Log warning and continue
end
sequenceDiagram
autonumber
participant Pytest as PyTest Collector
participant CLI as CLI Options
participant Tests as Collected Items
CLI-->>Pytest: --pre/--post and --upgrade-deployment-modes
Pytest->>Tests: Inspect keywords (pre_upgrade/post_upgrade + modes)
alt Modes provided
Pytest->>Tests: Include pre/post only if keyword matches mode list
else No modes
Pytest->>Tests: Include all pre/post as usual
end
Pytest->>Pytest: Deselect non-matching upgrade tests
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 actionlint (1.7.7).github/workflows/add-remove-labels.ymlcould not read ".github/workflows/add-remove-labels.yml": open .github/workflows/add-remove-labels.yml: no such file or directory .github/workflows/add-welcome-comment-set-assignee.ymlcould not read ".github/workflows/add-welcome-comment-set-assignee.yml": open .github/workflows/add-welcome-comment-set-assignee.yml: no such file or directory .github/workflows/build-push-container-on-merge.ymlcould not read ".github/workflows/build-push-container-on-merge.yml": open .github/workflows/build-push-container-on-merge.yml: no such file or directory 🔧 YAMLlint (1.37.1).github/workflows/add-remove-labels.yml[Errno 2] No such file or directory: '.github/workflows/add-remove-labels.yml' .github/workflows/add-welcome-comment-set-assignee.yml[Errno 2] No such file or directory: '.github/workflows/add-welcome-comment-set-assignee.yml' .github/workflows/build-push-container-on-merge.yml[Errno 2] No such file or directory: '.github/workflows/build-push-container-on-merge.yml' Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (18)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/wip', '/lgtm', '/verified', '/cherry-pick', '/build-push-pr-image', '/hold'} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add no-op for --collect-must-gather in older versions
Description
We want devops to use --collect-must-gather by default, but backporting it isn't trivial. For now we want to add a mock option that does nothing to avoid breaking runs with older branches.
How Has This Been Tested?
Running locally with/without --collect-must-gather in different branches.
Merge criteria:
Summary by CodeRabbit
New Features
Tests
Documentation
Chores