Skip to content

fix: add no-op for --collect-must-gather in older versions#542

Merged
dbasunag merged 1 commit intoopendatahub-io:2.19from
adolfo-ab:collect-mock-gather
Aug 21, 2025
Merged

fix: add no-op for --collect-must-gather in older versions#542
dbasunag merged 1 commit intoopendatahub-io:2.19from
adolfo-ab:collect-mock-gather

Conversation

@adolfo-ab
Copy link
Copy Markdown
Contributor

add no-op for --collect-must-gather in older versions

Description
We want devops to use --collect-must-gather by default, but backporting it isn't trivial. For now we want to add a mock option that does nothing to avoid breaking runs with older branches.

How Has This Been Tested?
Running locally with/without --collect-must-gather in different branches.

Merge criteria:
The commits are squashed in a cohesive manner and have meaningful messages.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work

@adolfo-ab adolfo-ab requested a review from a team as a code owner August 21, 2025 13:38
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 21, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dbasunag dbasunag merged commit 456dcdd into opendatahub-io:2.19 Aug 21, 2025
9 of 11 checks passed
@dbasunag
Copy link
Copy Markdown
Collaborator

/cherry-pick 2.16

@github-actions
Copy link
Copy Markdown

Status of building tag 2.19: failure.
Status of pushing tag 2.19 to image registry: skipped.

@rhods-ci-bot
Copy link
Copy Markdown
Contributor

Error cherry-picking.

Auto-merging conftest.py
CONFLICT (content): Merge conflict in conftest.py
error: could not apply 456dcdd... add --collect-must-gather mock option (#542)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

@rhods-ci-bot
Copy link
Copy Markdown
Contributor

‼️ cherry pick action failed.
See: https://github.com/opendatahub-io/opendatahub-tests/actions/runs/17128704589

@rhods-ci-bot
Copy link
Copy Markdown
Contributor

Error cherry-picking.

Auto-merging conftest.py
CONFLICT (content): Merge conflict in conftest.py
error: could not apply 456dcdd... add --collect-must-gather mock option (#542)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

@rhods-ci-bot
Copy link
Copy Markdown
Contributor

‼️ cherry pick action failed.
See: https://github.com/opendatahub-io/opendatahub-tests/actions/runs/17128816572

@adolfo-ab
Copy link
Copy Markdown
Contributor Author

/cherry-pick 2.16

@rhods-ci-bot
Copy link
Copy Markdown
Contributor

Error cherry-picking.

Auto-merging conftest.py
CONFLICT (content): Merge conflict in conftest.py
error: could not apply 456dcdd... add --collect-must-gather mock option (#542)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

@rhods-ci-bot
Copy link
Copy Markdown
Contributor

‼️ cherry pick action failed.
See: https://github.com/opendatahub-io/opendatahub-tests/actions/runs/17130953369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants