Skip to content

Remove LMEval HF test from disconnected#649

Merged
dbasunag merged 1 commit intoopendatahub-io:2.19from
sheltoncyril:2.19-patch
Sep 29, 2025
Merged

Remove LMEval HF test from disconnected#649
dbasunag merged 1 commit intoopendatahub-io:2.19from
sheltoncyril:2.19-patch

Conversation

@sheltoncyril
Copy link
Copy Markdown
Contributor

This PR removes the smoke flag from a test that needs Internet preventing it from running on disconnected

@sheltoncyril sheltoncyril marked this pull request as ready for review September 26, 2025 14:47
@sheltoncyril sheltoncyril requested a review from a team as a code owner September 26, 2025 14:47
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 26, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/cherry-pick', '/wip', '/verified', '/build-push-pr-image', '/hold', '/lgtm'}

@dbasunag dbasunag merged commit 3004340 into opendatahub-io:2.19 Sep 29, 2025
9 checks passed
@github-actions
Copy link
Copy Markdown

Status of building tag 2.19: success.
Status of pushing tag 2.19 to image registry: success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants