Skip to content

Fix model metrics and tests dd extra validation #898

Merged
mwaykole merged 5 commits intoopendatahub-io:2.25from
mwaykole:2.25
Dec 2, 2025
Merged

Fix model metrics and tests dd extra validation #898
mwaykole merged 5 commits intoopendatahub-io:2.25from
mwaykole:2.25

Conversation

@mwaykole
Copy link
Copy Markdown
Member

@mwaykole mwaykole commented Dec 2, 2025

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 2, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the size/l label Dec 2, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 2, 2025

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/build-push-pr-image', '/cherry-pick', '/hold', '/verified', '/lgtm', '/wip'}

@mwaykole mwaykole enabled auto-merge (squash) December 2, 2025 08:32
@mwaykole
Copy link
Copy Markdown
Member Author

mwaykole commented Dec 2, 2025

/lgtm

1 similar comment
@threcc
Copy link
Copy Markdown
Contributor

threcc commented Dec 2, 2025

/lgtm

@mwaykole mwaykole merged commit 01754ce into opendatahub-io:2.25 Dec 2, 2025
10 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 2, 2025

Status of building tag 2.25: success.
Status of pushing tag 2.25 to image registry: success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants