Skip to content

Update to Mysql image tag to pick the latest#900

Merged
dbasunag merged 1 commit intoopendatahub-io:mainfrom
dbasunag:update_mysql_image
Dec 3, 2025
Merged

Update to Mysql image tag to pick the latest#900
dbasunag merged 1 commit intoopendatahub-io:mainfrom
dbasunag:update_mysql_image

Conversation

@dbasunag
Copy link
Copy Markdown
Collaborator

@dbasunag dbasunag commented Dec 2, 2025

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • Chores
    • Updated MySQL container image digest in test infrastructure to a newer version.
    • Removed MySQL authentication plugin configuration from test deployment templates.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 2, 2025

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/wip', '/build-push-pr-image', '/cherry-pick', '/lgtm', '/hold', '/verified'}

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 2, 2025

📝 Walkthrough

Walkthrough

Two files updated: the MySQL Docker image digest constant in the test configuration was replaced with a different SHA256 hash, and the MySQL authentication plugin argument was removed from the deployment template's container arguments.

Changes

Cohort / File(s) Summary
Test constants update
tests/model_registry/constants.py
Updated MR_DB_IMAGE_DIGEST constant value from public.ecr.aws/docker/library/mysql@sha256:9de9d54fecee6253130e65154b930978b1fcc336bcc86dfd06e89b72a2588ebe to public.ecr.aws/docker/library/mysql@sha256:28540698ce89bd72f985044de942d65bd99c6fadb2db105327db57f3f70564f0
Deployment template configuration
tests/model_registry/utils.py
Removed --default-authentication-plugin=mysql_native_password argument from container args in the deployment template

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify the new MySQL image digest is correct and properly formatted
  • Confirm that removing the authentication plugin argument does not break existing tests or deployment behavior

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title describes updating the MySQL image tag, which directly corresponds to the main change in the PR: updating the MR_DB_IMAGE_DIGEST constant to a different SHA256 digest.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c29e38 and a25240c.

📒 Files selected for processing (2)
  • tests/model_registry/constants.py (1 hunks)
  • tests/model_registry/utils.py (0 hunks)
💤 Files with no reviewable changes (1)
  • tests/model_registry/utils.py
🔇 Additional comments (2)
tests/model_registry/constants.py (2)

44-44: Verify authentication compatibility after removing the mysql_native_password plugin.

According to the AI summary, the related change in tests/model_registry/utils.py removed the --default-authentication-plugin=mysql_native_password argument. Combined with this image update, this could be a breaking change if:

  • The new MySQL image defaults to caching_sha2_password (MySQL 8.0+ behavior)
  • Test client libraries don't support caching_sha2_password
  • Existing test credentials or connection logic assumes mysql_native_password

Please confirm that the model registry tests and client connections are compatible with the new authentication mechanism.


44-44: Clarify image versioning approach: digest-based pins vs. "latest" tag.

Using a SHA256 digest pins the image to a specific immutable version, which contradicts the PR title's claim to "pick the latest." If the intent is to use the latest stable MySQL version, consider using the public.ecr.aws/docker/library/mysql:8.0 tag instead of a digest, or update the PR title to reflect that this is a specific pinned version. If digest pinning is intentional for reproducibility, clarify this in the PR description and provide the corresponding MySQL version number for documentation purposes.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@fege fege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dbasunag dbasunag merged commit 98345c2 into opendatahub-io:main Dec 3, 2025
9 checks passed
@dbasunag dbasunag deleted the update_mysql_image branch December 3, 2025 12:24
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 3, 2025

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

mwaykole pushed a commit to mwaykole/opendatahub-tests that referenced this pull request Jan 23, 2026
Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants