Skip to content

Fix: Increated timeout to avoid loading/pending issue of model#910

Merged
dbasunag merged 1 commit intoopendatahub-io:mainfrom
kpunwatk:fix_timeout
Dec 4, 2025
Merged

Fix: Increated timeout to avoid loading/pending issue of model#910
dbasunag merged 1 commit intoopendatahub-io:mainfrom
kpunwatk:fix_timeout

Conversation

@kpunwatk
Copy link
Copy Markdown
Contributor

@kpunwatk kpunwatk commented Dec 4, 2025

On v3.0 fixed the TestDriftMetrics.test_drift_send_inference[db-storage] the gaussian_credit_model fixture tries to deploy an InferenceService (ISVC) using KServe/MLServer. Specifically, the model never reaches the Loaded.

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • Tests
    • Extended deployment registration polling timeout to improve test reliability during extended wait scenarios.

✏️ Tip: You can customize this high-level summary in your review settings.

	modified:   tests/model_explainability/trustyai_service/trustyai_service_utils.py
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 4, 2025

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/build-push-pr-image', '/verified', '/hold', '/lgtm', '/cherry-pick', '/wip'}

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 4, 2025

📝 Walkthrough

Walkthrough

A single timeout parameter was increased from 10 minutes to 20 minutes in a utility function that polls for ISVC deployment registration, with no other logic modifications.

Changes

Cohort / File(s) Change Summary
Timeout Configuration
tests/model_explainability/trustyai_service/trustyai_service_utils.py
Increased wait timeout in wait_for_isvc_deployment_registered_by_trustyai_service from Timeout.TIMEOUT_10MIN to Timeout.TIMEOUT_20MIN

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single parameter adjustment with no logic changes or control flow modifications
  • Straightforward timeout increase for test robustness

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title indicates a timeout fix for model loading/pending issues, which aligns with the changeset that increased the wait timeout from 10 minutes to 20 minutes.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dbasunag dbasunag merged commit 175b58b into opendatahub-io:main Dec 4, 2025
9 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 4, 2025

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

mwaykole pushed a commit to mwaykole/opendatahub-tests that referenced this pull request Jan 23, 2026
…atahub-io#910)

modified:   tests/model_explainability/trustyai_service/trustyai_service_utils.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants