fix: Ignore Konflux .tekton yaml files during yamllint#19
Conversation
📝 WalkthroughWalkthroughThe Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.yamllint.yml (1)
2-3: Use a root-anchored directory ignore pattern for precision.The pattern
.tektonmatches any.tektonpath segment anywhere in the repository tree, not just the root directory. To ignore only the repository-root Tekton folder, use/.tekton/.Proposed diff
ignore: | - .tekton + /.tekton/🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.yamllint.yml around lines 2 - 3, Replace the non-root-anchored ignore pattern ".tekton" with a root-anchored directory pattern so only the repository root Tekton folder is ignored; update the ignore entry (the string ".tekton" in .yamllint.yml) to use "/.tekton/" (or "/.tekton") to precisely target the root directory.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.yamllint.yml:
- Around line 2-3: Replace the non-root-anchored ignore pattern ".tekton" with a
root-anchored directory pattern so only the repository root Tekton folder is
ignored; update the ignore entry (the string ".tekton" in .yamllint.yml) to use
"/.tekton/" (or "/.tekton") to precisely target the root directory.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: d0fd325f-0f3d-4ee3-874b-9055c3c45e28
📒 Files selected for processing (1)
.yamllint.yml
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LukaszCmielowski The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@nsingla please review this PR. Thx. |
Description of your changes:
Ignore Konflux .tekton yaml files during yamllint
Checklist:
Pre-Submission Checklist
Learn more about the pull request title convention used in this repository.
Additional Checklist Items for New or Updated Components/Pipelines
metadata.yamlincludes freshlastVerifiedtimestampare present and complete
snake_casenaming conventionSummary by CodeRabbit