Skip to content

fix: Ignore Konflux .tekton yaml files during yamllint#19

Open
dryszka wants to merge 1 commit into
opendatahub-io:mainfrom
dryszka:patch-1
Open

fix: Ignore Konflux .tekton yaml files during yamllint#19
dryszka wants to merge 1 commit into
opendatahub-io:mainfrom
dryszka:patch-1

Conversation

@dryszka
Copy link
Copy Markdown

@dryszka dryszka commented Apr 2, 2026

Description of your changes:
Ignore Konflux .tekton yaml files during yamllint

Checklist:

Pre-Submission Checklist

Additional Checklist Items for New or Updated Components/Pipelines

  • metadata.yaml includes fresh lastVerified timestamp
  • All required files
    are present and complete
  • OWNERS file lists appropriate maintainers
  • README provides clear documentation with usage examples
  • Component follows snake_case naming convention
  • No security vulnerabilities in dependencies
  • Containerfile included if using a custom base image

Summary by CodeRabbit

  • Chores
    • Updated YAML linting configuration to exclude specified directories from validation checks.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 2, 2026

📝 Walkthrough

Walkthrough

The .yamllint.yml configuration file is modified to add an ignore block that excludes the .tekton directory from linting validation. The modification preserves all existing configuration settings, including the default extends configuration and existing rule definitions for line-length and truthy values. Three lines are added with no deletions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding ignore rules for .tekton YAML files to yamllint configuration.
Description check ✅ Passed The pull request description is minimal but includes the required template structure with a clear one-line change description and all checklist sections.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from HumairAK and nsingla April 2, 2026 18:36
@dryszka dryszka changed the title fix: Ignore .tekton yaml files during yamllint fix: Ignore Konflux .tekton yaml files during yamllint Apr 2, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.yamllint.yml (1)

2-3: Use a root-anchored directory ignore pattern for precision.

The pattern .tekton matches any .tekton path segment anywhere in the repository tree, not just the root directory. To ignore only the repository-root Tekton folder, use /.tekton/.

Proposed diff
 ignore: |
-  .tekton
+  /.tekton/
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.yamllint.yml around lines 2 - 3, Replace the non-root-anchored ignore
pattern ".tekton" with a root-anchored directory pattern so only the repository
root Tekton folder is ignored; update the ignore entry (the string ".tekton" in
.yamllint.yml) to use "/.tekton/" (or "/.tekton") to precisely target the root
directory.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.yamllint.yml:
- Around line 2-3: Replace the non-root-anchored ignore pattern ".tekton" with a
root-anchored directory pattern so only the repository root Tekton folder is
ignored; update the ignore entry (the string ".tekton" in .yamllint.yml) to use
"/.tekton/" (or "/.tekton") to precisely target the root directory.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: d0fd325f-0f3d-4ee3-874b-9055c3c45e28

📥 Commits

Reviewing files that changed from the base of the PR and between ff7b395 and d33e150.

📒 Files selected for processing (1)
  • .yamllint.yml

Copy link
Copy Markdown

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cc @nsingla

@LukaszCmielowski
Copy link
Copy Markdown

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LukaszCmielowski
Once this PR has been reviewed and has the lgtm label, please assign nsingla for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LukaszCmielowski
Copy link
Copy Markdown

@nsingla please review this PR. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants