Fix vLLM image reference and add pull secret verification#28
Fix vLLM image reference and add pull secret verification#28aneeshkp merged 1 commit intoopendatahub-io:mainfrom
Conversation
Signed-off-by: Aneesh Puttur <aneeshputtur@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR updates documentation to reference an updated vLLM container image registry and adds a verification command for the Sail Operator. Image registry references are changed from a tech-preview registry to a CUDA-based production registry across two documentation files. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aneeshkp, anishasthana The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
registry.redhat.io/rhaiis-tech-preview/vllm-openai-rhel9to
registry.redhat.io/rhaiis/vllm-cuda-rhel9which is the actual image used in the chartsChanges
README.md— addpodman pull registry.redhat.io/rhaiis/vllm-cuda-rhel9:latestverification stepdocs/deploying-llm-d-on-managed-kubernetes.md— fix vLLM image in pull secret verificationand component reference table
Test plan
podman pull registry.redhat.io/rhaiis/vllm-cuda-rhel9:latestworks with valid credentialsSummary by CodeRabbit