Add skills list to docs-skills plugin entry#69
Conversation
|
Warning Review limit reached
More reviews will be available in 41 minutes and 36 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (11)
📝 WalkthroughWalkthroughThe generator now optionally fetches remote skills from GitHub, parses Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes 🚥 Pre-merge checks | ✅ 9 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (9 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aireilly
force-pushed
the
add-docs-skills-plugin
branch
from
ea539ea to
58859cb
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@registry.yaml`:
- Around line 691-837: The registry entry exposing many user-invocable skills is
still tied to a mutable source ref, which risks supply-chain drift for sensitive
actions. Pin the plugin in the registry metadata to an immutable revision by
updating the surrounding source reference in the same entry (the one containing
the skill list with jira-writer and docs-workflow-create-merge-request) to a
fixed commit or tag, and keep the exposed skill set unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 0d194032-b94e-4cc0-a906-d8442c566b90
📒 Files selected for processing (1)
registry.yaml
aireilly
force-pushed
the
add-docs-skills-plugin
branch
2 times, most recently
from
6b3e5b4 to
68bc92f
Compare
|
Yep, this will work. Small issue, however: skills_dir is set to .claude/skills but the repo's skills live at skills/ (top-level). There's no .claude/skills/ directory in opendatahub-io/docs-skills (https://github.com/opendatahub-io/docs-skills). current (wrong path)skills_dir: .claude/skills should beskills_dir: skills The site will render correctly either way (it reads the skills: list from registry.yaml), but Claude Code uses skills_dir to discover skills at install time via the marketplace — so with the wrong path, /plugin install will succeed but none of the skills will actually load. |
aireilly
force-pushed
the
add-docs-skills-plugin
branch
3 times, most recently
from
3cbcd9b to
573c112
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/deploy-site.yml:
- Around line 27-30: Pin the PyYAML dependency in the repo-managed
site/requirements.txt and remove the separate runtime install from the Pages
workflow. Update the dependency list used by the site build so it includes a
version-pinned pyyaml entry, and then delete the ad-hoc pip install pyyaml step
from the Install dependencies block in the deploy-site workflow. Use the
existing site/requirements.txt and the workflow’s dependency-install step as the
locations to adjust.
In `@scripts/generate_site.py`:
- Around line 808-810: The remote skill discovery flow is currently defaulting
discover_remote_skills to the mutable main branch, which allows unreviewed
upstream changes to affect published content. Update discover_remote_skills so
source.ref must be provided explicitly, and add validation to reject
non-immutable refs unless an explicit override is intended; use the
discover_remote_skills and tree_url paths to ensure the GitHub tree fetch only
accepts pinned refs for marketplace builds.
- Around line 1047-1055: In the discovery flow inside the skill generation
logic, the exception handling currently always warns and then continues even
when no cached data exists. Update the fetch_remote/repo branch around
discover_remote_skills, save_discovered, and load_discovered so that a failure
only logs a warning if load_discovered() already provided usable discovered
data; otherwise re-raise the exception and stop generation. Keep the existing
discovered variable/path handling intact so the code can distinguish a valid
cache from a cold-build failure.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 672ce8b7-8e24-4ff7-a51b-19d75686d6d4
📒 Files selected for processing (9)
.github/workflows/deploy-site.yml.gitignorescripts/generate_site.pysite/docs/categories/documentation.mdsite/docs/index.mdsite/docs/llms-full.txtsite/docs/llms.txtsite/docs/plugins/docs-skills/index.mdsite/docs/plugins/index.md
✅ Files skipped from review due to trivial changes (4)
- site/docs/plugins/index.md
- .gitignore
- site/docs/categories/documentation.md
- site/docs/index.md
aireilly
force-pushed
the
add-docs-skills-plugin
branch
3 times, most recently
from
f474579 to
76c19ad
Compare
Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Auto-discover docs-skills from source repo via GitHub API Replace the manually-maintained skills list for docs-skills in registry.yaml with automatic discovery from the source repository. generate_site.py --fetch-remote-skills fetches SKILL.md frontmatter in parallel and caches results in _discovered.yaml (gitignored). The deploy workflow runs with the flag so the published site always shows the full skills table with links to the source repo. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> Signed-off-by: Aidan Reilly <aireilly@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
aireilly
force-pushed
the
add-docs-skills-plugin
branch
from
76c19ad to
1033522
Compare
2 participants
Summary
--fetch-remote-skillsflag togenerate_site.pythat auto-discovers skills by fetching SKILL.md frontmatter from GitHub (parallel via ThreadPoolExecutor)_discovered.yaml(gitignored) and rendered on the plugin page with links to the source repo — no individual.mdpages generated--fetch-remote-skillsso the published site always shows the full skills tableTest plan
python3 scripts/validate_registry.pypassespython3 scripts/generate_site.py --fetch-remote-skillsdiscovers 49 skills, generates plugin page with GitHub linkspython3 scripts/generate_site.py(without flag) reads cache, produces same resultls site/docs/plugins/docs-skills/shows onlyindex.mdand_discovered.yaml— no individual skill.mdfilessite/docs/llms.txtlists docs-skills skills with GitHub URLs🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes