Squash and merge changes from upstrem/rhoai-3.2

[shruthis4]

Purpose of this PR

This is same as #9. I just ported them to my local fork.

Proposed changes:

• <Change 1>
• <Change 2>
• <Change 3>

Change Category

• Bugfix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that could affect existing functionality)
• Documentation update

Rationale

Checklist

• I have conducted a self-review of my own code.
• I have updated documentation accordingly.
• I have added tests that prove my changes are effective or that my feature works.
• Existing unit tests pass locally with my changes.

Additional Notes

Summary by CodeRabbit

Chores

• Set up automated Helm chart release pipeline for Spark Operator, streamlining the distribution of chart updates and enabling more frequent, reliable releases.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The changes introduce GitHub Actions automation for releasing Helm charts for the Spark Operator. A new workflow is triggered on pushes to the odh branch affecting Spark Operator chart files and runs the Chart Releaser action. A configuration file specifies Chart Releaser settings for the repository.

Changes

Cohort / File(s)	Change Summary
Helm Chart Release Automation .github/workflows/helm-release.yaml, cr.yaml	Adds GitHub Actions workflow to automate Helm chart releases triggered on odh branch pushes affecting chart files. Includes Chart Releaser configuration specifying repository owner, charts directory, GitHub Pages target branch, and release naming template.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

• Verify repository URL, branch names, and configuration values match intended targets
• Confirm secrets.GITHUB_TOKEN reference is valid and has required permissions
• Check that trigger conditions (odh branch + Chart.yaml/values.yaml changes) are correct

Poem

🐰 A workflow hops through GitHub's gates,
Chart Releaser eagerly awaits,
When odh branch receives a push,
Helm charts release in a rush,
Automation's magic, swift as a hare! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title mentions merging changes from 'upstrem/rhoai-3.2', but the actual changes add GitHub Actions workflow automation for Helm chart releases specific to the Spark Operator, with no visible connection to the stated source branch.	Update the title to accurately reflect the actual changes, such as 'Add Helm chart release workflow for Spark Operator' or clarify the relationship between the stated merge source and the workflow additions.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[akram]

/lgtm

[akram]

/approve

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

.github/workflows/helm-release.yaml (2)

7-9: Path filters may be too restrictive.

The workflow only triggers when Chart.yaml or values.yaml are modified. Changes to chart templates, helpers, or other files in charts/spark-operator-chart/ will not trigger a release.

If this is intentional (e.g., releases are controlled only by version bumps in Chart.yaml), consider adding a comment explaining the rationale.

🔎 Alternative: Broaden the path filter to include all chart files

    paths:
-      - charts/spark-operator-chart/Chart.yaml
-      - charts/spark-operator-chart/values.yaml
+      - charts/spark-operator-chart/**

---

11-36: Consider adding failure notifications for operational visibility.

The workflow lacks explicit error handling or notifications. While GitHub Actions will mark the workflow as failed, consider adding a notification step to alert maintainers of release failures.

🔎 Example: Add a failure notification step

jobs:
  release:
    permissions:
      contents: write
    runs-on: ubuntu-latest
    steps:
      # ... existing steps ...
      
      - name: Notify on failure
        if: failure()
        run: |
          echo "::error::Chart release workflow failed. Check logs for details."
          # Add additional notification logic (e.g., Slack, email) if needed

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8714a45 and 5d80b49.

📒 Files selected for processing (2)

• .github/workflows/helm-release.yaml (1 hunks)
• cr.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)

• GitHub Check: e2e-test (v1.31.4)
• GitHub Check: e2e-test (v1.30.8)
• GitHub Check: e2e-test (v1.32.0)
• GitHub Check: e2e-test (v1.28.15)
• GitHub Check: e2e-test (v1.29.12)
• GitHub Check: e2e-test (v1.27.16)
• GitHub Check: e2e-test (v1.25.16)
• GitHub Check: e2e-test (v1.26.15)
• GitHub Check: e2e-test (v1.24.17)
• GitHub Check: build-helm-chart
• GitHub Check: code-check
• GitHub Check: build-spark-operator

🔇 Additional comments (2)

.github/workflows/helm-release.yaml (1)

14-15: Permissions and authentication configuration looks correct.

The workflow properly configures:

• contents: write permission (lines 14-15): Required for chart-releaser to create GitHub releases and push to gh-pages branch
• Git identity using GITHUB_ACTOR (lines 25-26): Standard practice for automated commits
• GITHUB_TOKEN (line 36): Provides authentication for the chart-releaser action

Also applies to: 23-26, 35-36

cr.yaml (1)

1-8: Configuration is correctly set up for Chart Releaser.

The cr.yaml file references all required resources:

• The gh-pages branch exists and is ready to receive chart index updates
• The charts directory contains the spark-operator-chart with a valid Chart.yaml file
• The repository owner and name are correctly configured

All prerequisites for the Chart Releaser workflow are in place.

[Vedant-Deshpande]

/lgtm