Conversation
WalkthroughUpdated GitHub Actions workflow triggers in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
With this change, this workflow will run every time you push to the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/openshift-docling-e2e.yaml (1)
9-13: Update workflow_dispatch defaults to match the primary branch.The workflow_dispatch input description (line 9) and default value (line 13) still reference "main", but the push trigger now uses "odh" as the primary branch. This inconsistency could confuse users manually triggering the workflow.
🔎 Proposed fix to update references from "main" to "odh"
# FUTURE USE: # Maintainers can provide a PR number or existing upstream branch name to run this # job against. If no PR number or branch name is provided, this job will run against - # content in the "main" branch instead. + # content in the "odh" branch instead. pr_or_branch: description: "Pull request number or branch name" required: true - default: "main" + default: "odh"
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/openshift-docling-e2e.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: e2e-test (v1.30.8)
- GitHub Check: e2e-test (v1.31.4)
- GitHub Check: e2e-test (v1.32.0)
- GitHub Check: e2e-test (v1.25.16)
- GitHub Check: e2e-test (v1.24.17)
- GitHub Check: e2e-test (v1.26.15)
- GitHub Check: e2e-test (v1.27.16)
- GitHub Check: e2e-test (v1.29.12)
- GitHub Check: e2e-test (v1.28.15)
- GitHub Check: build-helm-chart
- GitHub Check: build-spark-operator
- GitHub Check: code-check
🔇 Additional comments (1)
.github/workflows/openshift-docling-e2e.yaml (1)
16-16: LGTM! Push trigger correctly updated to primary branch.The change to trigger on the
odhbranch aligns with the PR objectives, asodhis the repository's primary branch.
Rename "main" to "odh". The "odh" branch is the primary branch in this repository, so we should not configure this job to run on "main". Remove my "ec2-github-runner-RHAIENG-2487" work-in-progress branch from the configuration. Now that we have merged this file, we don't need this in the configuration any more. If we want to run this workflow on other work-in-progress branches, we can add those here at a future time.
ktdreyer
force-pushed
the
ec2-github-runner-RHAIENG-2487
branch
from
04f7f95 to
7ee1c96
Compare
|
Hi Ken, This is integrated in my #21, so closing this PR |
2 participants
Rename
maintoodh. Theodhbranch is the primary branch in this repository, so we should not configure this job to run on "main".Remove my
ec2-github-runner-RHAIENG-2487work-in-progress branch from the configuration. Now that we have merged this file, we don't need this in the configuration any more. If we want to run this workflow on other work-in-progress branches, we can add those here at a future time.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.