Sync with Kubeflow master 3-17-26#69
Open
alimaredia wants to merge 23 commits intoopendatahub-io:mainfrom
Open
Sync with Kubeflow master 3-17-26#69alimaredia wants to merge 23 commits intoopendatahub-io:mainfrom
alimaredia wants to merge 23 commits intoopendatahub-io:mainfrom
Conversation
* feat: add namespace matcher utility for label-based filtering Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * feat: add --namespace-selector flag to controller Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * feat: update SparkApplication controller to support namespace selector Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * feat: update ScheduledSparkApplication controller for namespace selector Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * feat: update ScheduledSparkApplication controller for namespace selector Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * feat: add Helm chart support for namespace selector Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * test: add comprehensive tests for namespace selector feature Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> --------- Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.42.0 to 0.45.0. - [Commits](golang/crypto@v0.42.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…flow#2797) * refactor: use k8s.io/component-base/version Signed-off-by: Yi Chen <github@chenyicn.net> * build(Makefile): update version target and LDFLAGS Signed-off-by: Yi Chen <github@chenyicn.net> --------- Signed-off-by: Yi Chen <github@chenyicn.net>
…low#2817) * feat: expose metrics-labels flag via Helm values.yaml Signed-off-by: Igor Stepanenko <igorstepanenko696@gmail.com> * Improve doc formatting Signed-off-by: Igor Stepanenko <igorstepanenko696@gmail.com> * Revert Helm chart version bump Signed-off-by: Igor Stepanenko <igorstepanenko696@gmail.com> --------- Signed-off-by: Igor Stepanenko <igorstepanenko696@gmail.com>
Service mesh controllers like Istio rely on appProtocol to correctly identify and route application-level traffic. Without it, gRPC traffic to the spark-connect-server port is treated as opaque TCP, preventing proper HTTP/2 load balancing. Signed-off-by: wkd-woo <wkdwoos@gmail.com>
* feat: add welcome-new-contributors workflow Signed-off-by: Yi Chen <github@chenyicn.net> * remove team mention from new contributor welcome message Signed-off-by: Yi Chen <github@chenyicn.net> --------- Signed-off-by: Yi Chen <github@chenyicn.net>
…w#2829) Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Pavan More <pavansmore05@gmail.com>
…eflow#2834) Fixes kubeflow#2832 Signed-off-by: Pavan More <pavansmore05@gmail.com>
…beflow#2836) Signed-off-by: Pavan More <pavansmore05@gmail.com>
…on` controller (kubeflow#2841) Signed-off-by: Pavan More <pavansmore05@gmail.com>
…ion names (kubeflow#2827) Adds --scheduled-spark-application-timestamp-precision flag to configure timestamp format (nanos, micros, millis, seconds, minutes) for generated SparkApplication names, helping avoid Kubernetes 63-char name limits. Fixes kubeflow#2602 Signed-off-by: Pavan More <pavansmore05@gmail.com>
* feat: enable and generate OpenAPI schemas for SparkOperator APIs Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * feat: add tooling to generate and validate OpenAPI spec Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * feat: add generated OpenAPI spec for Spark Operator Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * feat: add tooling to generate Python client from OpenAPI spec Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * feat: add generated Python client for Spark Operator APIs Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * fix: align code generation with Trainer patterns Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * fix: align Spark swagger naming and Python SDK generation Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * docs: recommend isolated Python environments for SDK publishing Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> * fix: generate Python SDK models for v1alpha1 and v1beta2 APIs Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com> --------- Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com>
Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com>
Signed-off-by: vara-bonthu <vara.bonthu@gmail.com>
… Patches (kubeflow#2820) The kustomization.yaml had a duplicate entry for webhook_in_sparkapplications.yaml which appears to be a copy-paste error from the controller-runtime refactor. This commit: - Fixes the duplicate webhook patch entry in config/crd/kustomization.yaml - Adds webhook_in_scheduledsparkapplications.yaml for conversion webhook support - Adds cainjection_in_scheduledsparkapplications.yaml for cert-manager CA injection Both CRDs (SparkApplication and ScheduledSparkApplication) now have corresponding webhook and CA injection patch files, matching the intended kustomize configuration. Signed-off-by: roburishabh <roburishabh@outlook.com>
…2862) Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com>
…r flooding (kubeflow#2878) - Add label selector to ConfigMap cache filter in newCacheOptions() - Add label to buildPrometheusConfigMap() for cache visibility - Handle upgrade path for pre-existing ConfigMaps without the label using merge patch to avoid resourceVersion rejection and preserve existing labels - Propagate label on ConfigMap updates, not just creation - Add filteredCacheClient test wrapper to simulate label-filtered informer cache - Add test coverage for label assertion and upgrade scenario exercising the full Get->NotFound->Create->AlreadyExists->Patch code path Signed-off-by: roburishabh <roburishabh@outlook.com>
…ow#2861) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 6.0.0 to 7.0.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v6...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 7.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.0 to 6.0.2. - [Release notes](https://github.com/actions/checkout/releases) - [Commits](actions/checkout@v5...v6.0.2) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* update integration test k8s matrix Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com> * update kind version Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com> --------- Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
…/.github/workflows (kubeflow#2847) Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.33.1 to 0.34.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@0.33.1...0.34.0) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-version: 0.34.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Important Review skippedToo many files! This PR contains 300 files, which is 150 over the limit of 150. ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (300)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required. |
Signed-off-by: Ali Maredia <amaredia@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Proposed changes:
Change Category
Rationale
Checklist
Additional Notes