feat: Add training progression tracking feature for RHAITrainer type implementation#20
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5c72c15 to
35d006e
Compare
66539e5 to
b3898a4
Compare
…ementation Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
35d006e to
b22f653
Compare
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
…ring trainjob termination Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
|
A few small nits, but lgtm otherwise. I'm happy for this to be merged after those nits are resolved. |
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
|
Thanks @abhijeet-dhumal! |
|
Thanks a million @astefanutti @robert-bell 🙌 |
What this PR does / why we need it:
RHOAIENG-38273
Implement controller support for polling and tracking training job progression from HTTP metrics endpoints exposed by experimental trainers (e.g., TransformersTrainer).
Related to :
opendatahub-io/kubeflow-sdk#21
Sample TrainJob tested it with :
wrapper-test.yaml
Sample suceeded trainjob status progression metrics: (the annotation is chnaged a bit in below picture to make all annotations viewable) -

Pre-stop hook injected by controller :

Checklist: