Skip to content

increasing resources on the wva controller for ooming #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anishasthana merged 1 commit into from
Mar 31, 2026
Merged

increasing resources on the wva controller for ooming #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,11 +134,11 @@ spec:
# More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
resources:
limits:
cpu: 500m
memory: 128Mi
cpu: "1"
memory: 1Gi
requests:
cpu: 10m
memory: 64Mi
memory: 256Mi
Comment on lines 135 to +141
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify the Helm chart resource values
fd -t f 'wva-deployment-controller-manager.yaml' --exec cat {} | grep -A 6 'resources:'

Repository: opendatahub-io/workload-variant-autoscaler

Length of output: 236

Helm chart resource values conflict with manifest; update charts/workload-variant-autoscaler/templates/manager/wva-deployment-controller-manager.yaml to match.

The Helm chart specifies lower resource limits and requests (memory limit: 512Mi, memory request: 64Mi) compared to this manifest (memory limit: 1Gi, memory request: 256Mi). Deployments using the Helm chart will remain vulnerable to OOM errors due to insufficient memory request allocation. Reconcile the resource values between both files.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@config/manager/manager.yaml` around lines 135 - 141, The Helm chart template
wva-deployment-controller-manager.yaml has resource values that conflict with
the manifest; update the chart so resources.limits.cpu = "1",
resources.limits.memory = "1Gi", resources.requests.cpu = "10m", and
resources.requests.memory = "256Mi" to match the values in manager.yaml (or
alternatively change manager.yaml to the chart values if you prefer the lower
profile) — ensure the four keys (resources.limits.cpu, resources.limits.memory,
resources.requests.cpu, resources.requests.memory) are consistent between the
manifest and the Helm template.

volumeMounts:
- name: prometheus-client-certs
mountPath: /etc/prometheus-certs
Expand Down
Loading