Skip to content

[Sync] odh to rhds#53

Closed
zdtsw wants to merge 26 commits intoopendatahub-io:mainfrom
red-hat-data-services:sync_odh_rhds
Closed

[Sync] odh to rhds#53
zdtsw wants to merge 26 commits intoopendatahub-io:mainfrom
red-hat-data-services:sync_odh_rhds

Conversation

@zdtsw
Copy link
Copy Markdown
Member

@zdtsw zdtsw commented Apr 2, 2026

Description

to fix merge conflict
https://github.com/red-hat-data-services/rhods-devops-infra/actions/runs/23894628187/job/69676202347

after this is merge, we should run https://github.com/red-hat-data-services/rhods-devops-infra/actions/workflows/upstream-auto-merge.yaml again without failure

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • Chores
    • Added Renovate configuration to automate dependency updates.
    • Updated Docker builder stage base image digest.

Peter Keappock and others added 26 commits February 25, 2026 11:21
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
…est to 3efce46 (#23)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
…est to b3b98e0 (#24)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
…est to e421039 (#28)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
…est to 71101fd (#32)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
…est to 6da1160 (#35)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
…r digest to 69f5c98 (#36)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
(cherry picked from commit affba38)
Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
(cherry picked from commit 35808f1)
- keep only one replica for deployment via Kustomize
- add serect for SA as optional for mount
  - if our EPP disable --metrics-endpoint-auth then no need it
  - by default GIE set true, so we need it otherwise will failed to get
    metrics
- fix cert from CM openshift-service-ca.crt
- add missing RBAC on inferencepool and deployment/scale
- add missing rolebinding on controller for the monitoring view
Signed-off-by: Wen Zhou <wenzhou@redhat.com>

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit d442a76)
(cherry picked from commit df8059d)
- remove replica set in the deployment
- make mount not optional
- use existing path in the pod, skip configmap and mount

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit a5b8c32)
(cherry picked from commit 0c725d0)
- remove comments

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 1f6c90f)
(cherry picked from commit b7f6aa3)
[cherry-pick]  llm-d 0.5.1 release + fix to RHDS 3.4EA2 release
…est to 3cdf0d1 (#42)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
[cherry-pick] update: for ODH and RHDS we need bypass reconcile by Operator on configmap
…est to 8b211cc (#46)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
…r digest to 83006d5 (#47)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
…est to f8315b3 (#53)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
…est to 22c5f0e (#56)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
…est to 2830e4b (#61)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
…est to 0f4f6f7 (#62)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

Unsigned commits detected! Please sign your commits.

For instructions on how to set up GPG/SSH signing and verify your commits, please see GitHub Documentation.

@zdtsw zdtsw requested a review from shuynh2017 April 2, 2026 10:20
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 2, 2026

📝 Walkthrough

Walkthrough

Two configuration updates: addition of .github/renovate.json extending a shared Renovate preset from an external source, and update of the Dockerfile.konflux builder stage base image digest for registry.redhat.io/ubi9/go-toolset:9.7.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Security considerations

Renovate external preset dependency: The new .github/renovate.json delegates configuration to github>red-hat-data-services/konflux-central//renovate/default-renovate.json. Verify that this external source is trustworthy and that updates to that preset won't inadvertently trigger unintended automated changes (e.g., overly aggressive dependency upgrades, unsafe version pinning). Ensure audit logging is enabled if not already present.

Base image digest update: Confirm the new digest for registry.redhat.io/ubi9/go-toolset:9.7 is legitimate and matches expected build artifacts. Verify against the Red Hat registry to exclude potential supply-chain compromise or tag manipulation. No CVE/CWE directly applicable here, but digest verification is critical for container security posture.

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title '[Sync] odh to rhds' is vague and does not clearly convey the actual changes, which involve updating Renovate configuration and Docker base image digests. Use a more specific title that reflects the primary changes, such as 'Add Renovate configuration and update base image digests' or 'Configure Renovate with red-hat-data-services preset'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@zdtsw zdtsw closed this Apr 2, 2026
@zdtsw
Copy link
Copy Markdown
Member Author

zdtsw commented Apr 2, 2026

close in favor of red-hat-data-services#71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants