Skip to content

fix: hardcode image to use params.env #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anishasthana merged 2 commits into from
Apr 7, 2026
Merged

fix: hardcode image to use params.env #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1db74fd
fix: hardcode image to use params.env
zdtsw Apr 6, 2026
93e707d
fix: add missing params.env for image configuration
zdtsw Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions config/openshift/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ resources:
- metrics-reader-token.yaml
- prometheus-metrics-reader-binding.yaml

configMapGenerator:
- envs:
- params.env
name: wva-parameters
generatorOptions:
disableNameSuffixHash: true
Comment thread
coderabbitai[bot] marked this conversation as resolved.

patches:
- path: configmap-patch.yaml
target:
Expand All @@ -29,4 +36,17 @@ patches:
kind: ServiceMonitor
name: controller-manager-metrics-monitor

replacements:
- source:
kind: ConfigMap
version: v1
name: wva-parameters
fieldPath: data.wva-controller-image
targets:
- select:
kind: Deployment
name: controller-manager
fieldPaths:
- spec.template.spec.containers.[name=manager].image
Comment thread
coderabbitai[bot] marked this conversation as resolved.

namespace: workload-variant-autoscaler-system
1 change: 1 addition & 0 deletions config/openshift/params.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
wva-controller-image=ghcr.io/llm-d/llm-d-workload-variant-autoscaler:v0.6-0
Loading