build(test): declare the markdown test dependency - #5424
Open
JessYanCoding wants to merge 1 commit into
Open
JessYanCoding wants to merge 1 commit into
JessYanCoding wants to merge 1 commit into
Conversation
tests/unittest/test_render_html_table.py imports markdown, but the package is not declared in any dependency group of pyproject.toml. A clean `uv pip install -e ".[test]"` therefore leaves it missing, and the resulting collection error is fatal to the whole pytest run: all 2889 collected tests are skipped and pytest exits 2. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
markdown(Python-Markdown) in thetestoptional-dependency grouptests/unittest/test_render_html_table.py:1doesimport markdown, but the package is notdeclared anywhere in
pyproject.toml— the only occurrence of the string"markdown"in that fileis inside
[project].keywords. A pytest collection error is fatal to the whole run, so on a clean.[test]environment the entire suite is skipped:This is not visible in CI because
.github/workflows/cli.ymlrunscoverage run, whosecommand_linetargets a single file rather than the suite.docs/requirements.txtcarriesmarkdown-gfm-admonitionfor the mkdocs build, but that file is not part of the test environment.Validation
uv pip install --dry-run -e ".[test]"on this branch resolvesmarkdown==3.10.3; onnext@ 04390cd it resolves nothing matchingmarkdownpython -m pytest tests/unittest --no-covcollects and executes2889 tests instead of exiting 2 at collection (remaining failures are pre-existing on
nextandunrelated to this change)
🤖 Generated with Claude Code