Skip to content

build(test): declare the markdown test dependency - #5424

Open
JessYanCoding wants to merge 1 commit into
opendatalab:nextfrom
JessYanCoding:build/test-dep-markdown
Open

JessYanCoding wants to merge 1 commit into
opendatalab:nextfrom
JessYanCoding:build/test-dep-markdown

Conversation

@JessYanCoding

Copy link
Copy Markdown

Summary

  • declare markdown (Python-Markdown) in the test optional-dependency group

tests/unittest/test_render_html_table.py:1 does import markdown, but the package is not
declared anywhere in pyproject.toml — the only occurrence of the string "markdown" in that file
is inside [project].keywords. A pytest collection error is fatal to the whole run, so on a clean
.[test] environment the entire suite is skipped:

$ python -m pytest tests/unittest --no-cov
collected 2889 items / 1 error
E   ModuleNotFoundError: No module named 'markdown'
!!!!!!!! Interrupted: 1 error during collection !!!!!!!!
$ echo $?
2

This is not visible in CI because .github/workflows/cli.yml runs coverage run, whose
command_line targets a single file rather than the suite. docs/requirements.txt carries
markdown-gfm-admonition for the mkdocs build, but that file is not part of the test environment.

Validation

  • uv pip install --dry-run -e ".[test]" on this branch resolves markdown==3.10.3; on
    next @ 04390cd it resolves nothing matching markdown
  • with the dependency present, python -m pytest tests/unittest --no-cov collects and executes
    2889 tests instead of exiting 2 at collection (remaining failures are pre-existing on next and
    unrelated to this change)
  • no source or test files touched, so there is nothing to regress

🤖 Generated with Claude Code

tests/unittest/test_render_html_table.py imports markdown, but the package
is not declared in any dependency group of pyproject.toml. A clean
`uv pip install -e ".[test]"` therefore leaves it missing, and the resulting
collection error is fatal to the whole pytest run: all 2889 collected tests
are skipped and pytest exits 2.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 25, 2026
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@JessYanCoding

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant