8.18 upgrade #18
Merged
8.18 upgrade #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5k4nd
force-pushed
the
8.18
branch
2 times, most recently
from
c0657d0 to
f0654c6
Compare
garaud
approved these changes
Jul 3, 2025
garaud
left a comment
garaud
left a comment
There was a problem hiding this comment.
Looks good to me.
I just left some comments.
...ft/elasticsearch/search/aggregations/bucket/geopointclustering/ParsedGeoPointClustering.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade from 7.x to 8.x targeting the latest 8.x release 8.18.4.
Changes
The main difference lies in the reduction phase for multi-bucket aggregations, which has significantly changed internally on the Elasticsearch side.
In version 7.x, the reduce() method would take a list of InternalMultiBucketAggregation instances and merge them into a single aggregated result.
In version 8.x, the process is now split into three distinct phases:
License change
To align with Elasticsearch’s license evolution, starting with this release (8.18.2.0), this plugin is now licensed under the AGPLv3.