-
Notifications
You must be signed in to change notification settings - Fork 1
Propose/dds over http #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@opendcs/opendcs-core-devs @opendcs/opendcs-dcpmon-devs @opendcs/opendcs-triage |
In my opinion https/websockets make sense for the bidirectonal communication but they're stateful and may not be as useful for something like dcpmon where a simple REST API could return what you need. (I.e. the client doesn't need anything more than short/long polling) But from a standpoint of client and server consumer applications a websocket server would be great. It would really let us take advantage of a pub/sub architecture. I would be curious what work has been done by the current OpenDCS web interface group, and if there is any potential overlap here.
I've never worked with SSE but from what I read it is server to client only. If it's simpler to implement then i'm sure it would work for things like configuration changes when saved on one client being pushed out to all the other clients, for example. @DanielTOsborne |
|
Agree, I certainly wouldn't set WebSockets as the only option, but we had some thoughts on "federation" of data. e.g. a trusted system could also push data. Based on work with SSE in the CWMS-Data-Api, it's not... terrible, but like you said doesn't seem commonly used. USACE/cwms-data-api#518 There is likely overlap with that group, but this is just defining what the standard should be, and pretty much for the reason above you just stated, why should your webdisplay require an additional Java API. But remember this is a standard for LRGSes to to communicate with each other and interested other system to know how to retrieve/push data. |
* Remove lowBattery and keep it in the additional properties for location
…s for server side cache reasons when the client wants to know wehn the status group was updated (if for example it's not read on the fly)
Add endpoints for DCP Monitor to OpenAPI Spec
Co-authored-by: Karl Tarbet <[email protected]>
Problem Description
The current DDS protocol assume a raw tcp port and requires that our applications directly implement all possible operations and contigiencies. It also makes assumptions about operations that are no longer as practical.
Solution
I have been describing a pure HTTPS based method of handling LRGS-LRGS/DECODES connection that should make development easier.
TODO/Desired.:
how you tested the change
Describe what was done to test the change. This section can be left blank
if automated tests demonstrating usage are provided in the PR.
Where the following done:
(Formerly called regression tests.)
If you aren't sure leave unchecked and we will help guide you to want needs changing where.