Skip to content

Conversation

@henrjk
Copy link
Member

@henrjk henrjk commented Jul 25, 2024

This must be merged with PR opendevstack/ods-jenkins-shared-library#1143. It supersedes PR #145.

Wording changes to be more inclusive of helm deployments. In particular removed language mentioning "pods" as these are dynamic and may change over time.
Makes language consistent if deployments are for things running in the future for example when a job is deployed.

Helm deployments are now reported in a new dedicated tables:

Deployment Status

Table surfacing the helm status information.

Deployment Mean

Table surfacing helm install parameters.

@anteloro-boeh anteloro-boeh force-pushed the feature/tir-rm-dyn-data-add-helm-status branch 2 times, most recently from ab03d7a to f6d18d0 Compare October 14, 2024 09:47
jafarre-bi
jafarre-bi previously approved these changes Nov 28, 2024
@matzehecht
Copy link
Contributor

I just stumbled over this PR. As far as I can see it changes some contents and a lot of stylings of the TIR document. Shouldn't those changes also be reflected in the TIR-infra. This second TIR is basically a copy of the main TIR with some adaptions. Merging this PR will most probably lead (again) to some unexpected differences between the TIR and the TIR-infra.
What do you think about this @jafarre-bi and @metmajer?

@jafarre-bi
Copy link

I just stumbled over this PR. As far as I can see it changes some contents and a lot of stylings of the TIR document. Shouldn't those changes also be reflected in the TIR-infra. This second TIR is basically a copy of the main TIR with some adaptions. Merging this PR will most probably lead (again) to some unexpected differences between the TIR and the TIR-infra. What do you think about this @jafarre-bi and @metmajer?

@matzehecht , The changes in this PR are targeted to OpenShift deployments, which correspond to ods-code and not ods-infra components. However, I will take another look at the TIR-infra template to see whether anything needs to be changed. Thanks for noting!

@matzehecht
Copy link
Contributor

I just stumbled over this PR. As far as I can see it changes some contents and a lot of stylings of the TIR document. Shouldn't those changes also be reflected in the TIR-infra. This second TIR is basically a copy of the main TIR with some adaptions. Merging this PR will most probably lead (again) to some unexpected differences between the TIR and the TIR-infra. What do you think about this @jafarre-bi and @metmajer?

@matzehecht , The changes in this PR are targeted to OpenShift deployments, which correspond to ods-code and not ods-infra components. However, I will take another look at the TIR-infra template to see whether anything needs to be changed. Thanks for noting!

At least I can see that the header css class was added to some cells of some tables which also exist in the TIR-infra. Also some phrasings changed which I think would also make sense to change in the TIR-infra (example below). But I am not 100% sure if I do not miss a reason to keep it as it is.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants