Docker plain helm chart #1035
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ | |
|
|
||
| ## The number of replicas to deploy. | ||
| ## For high availability use more than 1 replica | ||
| ## Before enabling check the official ODS documentation about replicate support: https://www.opendevstack.org/ods-documentation/opendevstack/latest/jenkins-shared-library/orchestration-pipeline.html#_known_limitations | ||
| replicaCount: 1 | ||
|
|
||
| imagePullSecrets: [] | ||
|
|
@@ -111,6 +112,7 @@ resources: | |
| memory: 16Mi | ||
| ephemeral-storage: 1Mi | ||
|
|
||
| ## Before enabling check the official ODS documentation about replicate support: https://www.opendevstack.org/ods-documentation/opendevstack/latest/jenkins-shared-library/orchestration-pipeline.html#_known_limitations | ||
|
There was a problem hiding this comment. Good idea to link to the official docs, but it's not enough, since many people will miss it. Please, make the warning explicit: multiple replicas aren't currently supported by the orchestration pipeline. There was a problem hiding this comment. @jafarre-bi we agreed on this in July and I've been waiting for the official doc to reference since then. Those values will get templated and there's no way to keep this information up-to-date then. the reference will stay valid longer. |
||
| autoscaling: | ||
| enabled: false | ||
| minReplicas: 1 | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be explicit that it must match
.Release.Name. Otherwise, it will still be inconsistent with the selector used elsewhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jafarre-bi we're supplying the same releaseName to helm upgrade (via helmReleaseName) as we use in the selector. .Release.Name is given by releaseName, we specify the selector. What inconsistency are you referring to?