Remove "Converted" and "Pending" from published_statuses (fixes #168)#169
Draft
bhaswarpurohit wants to merge 1 commit into
Draft
Remove "Converted" and "Pending" from published_statuses (fixes #168)#169bhaswarpurohit wants to merge 1 commit into
bhaswarpurohit wants to merge 1 commit into
Conversation
Per NIST IR 8588 §5.1, only approved submissions are publicly shown on the portal. The workflow in deployments-registry-data/README.md also places Converted inside the Unpublished subgraph. This reverts #166 and further removes Converted to bring the UI into agreement with the whitepaper. Note: this will hide all currently-visible records until the corresponding records in deployments-registry-data are promoted to an Approved* status.
mccalluc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the UI into agreement with the whitepaper (NIST IR 8588 §5.1): only approved submissions should be publicly shown.
Removes
ConvertedandPendingfrompublished_statuses. Final whitelist:Approved,Approved (Update Requested),Approved (Pending)._datahas 0Approved*records, so merging alone empties the registry. Land together with data-repo approvals + submodule bump.Closes #168