Skip to content

DB scan#98

Merged
mccalluc merged 8 commits into
mainfrom
96-scan-database
Jun 15, 2026
Merged

DB scan#98
mccalluc merged 8 commits into
mainfrom
96-scan-database

Conversation

@mccalluc

@mccalluc mccalluc commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • @Shoeboxam : Just at the high level, does the goal make sense, that users will need to create a LazyFrame from an existing database table, and then they'll use this LF in the Context? (Instead of the scan_csv that we use ubiquitously in the opendp docs)
  • @eddiestudies : Can you provide the code review?

@cla-bot cla-bot Bot added the cla-signed label Jun 12, 2026
@mccalluc mccalluc marked this pull request as ready for review June 12, 2026 21:43
eddiestudies
eddiestudies approved these changes Jun 15, 2026
View reviewed changes

@eddiestudies eddiestudies left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The Any in scan_database makes sense for now but makes me think it will need more tests in the future.

@mccalluc mccalluc merged commit 826ed81 into main Jun 15, 2026
7 checks passed
@mccalluc mccalluc deleted the 96-scan-database branch June 15, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eddiestudies eddiestudies eddiestudies approved these changes

@Shoeboxam Shoeboxam Awaiting requested review from Shoeboxam

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mccalluc @eddiestudies