[OEP 3916]: First pass at volume cloning implementation #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Charnock <[email protected]>
adam-lithus
force-pushed
the
adam/volume-clone-llm
branch
from
d324f0a to
201b3d3
Compare
5 tasks
Comment on lines
+309
to
+312
| let request = request.into_inner(); | ||
| debug!("create_volume parameters: {:#?}", request); | ||
|
|
||
| let _permit = self.create_volume_permit().await?; | ||
| let name = request.name.clone(); |
Member
There was a problem hiding this comment.
We seem to have removed the permit from here. We shouldn't do that. More over I think we should not change the order of any existing validations, that can change failure behaviour.
Abhinandan-Purkait
requested changes
May 9, 2025
Comment on lines
+621
to
+638
| Some(VolumeContentSourceInfo::Volume(source_volume_uuid)) => { | ||
| // Create volume from another volume (clone) | ||
| debug!( | ||
| "Creating volume clone {} from source volume {}", | ||
| uuid, source_volume_uuid | ||
| ); | ||
|
|
||
| // Append the 'fsId' : 'volume id' to the context if change was requested for the | ||
| // clone. | ||
| if volume.spec.content_source.is_some() | ||
| && context.clone_fs_id_as_volume_id().unwrap_or(false) | ||
| { | ||
| volume_context.insert("fsId".to_string(), volume_uuid.clone()); | ||
| // Check if source volume exists | ||
| match RestApiClient::get_client().get_volume(&source_volume_uuid).await { | ||
| Ok(_source_volume) => { | ||
| // Create a temporary snapshot of the source volume | ||
| let temp_snapshot_id = Uuid::new_v4(); | ||
|
|
||
| // Create the temporary snapshot | ||
| let snapshot = match RestApiClient::get_client() | ||
| .create_volume_snapshot(&source_volume_uuid, &temp_snapshot_id) | ||
| .await | ||
| { |
Member
There was a problem hiding this comment.
I would suggest to keep the other code as it is and just change this section in this order:
- Get source volume, if exists --> next step, else bail.
- If exists create a snapshot, if fails --> delete the snapshot and bail.
- If succeeds get the snapshot object, if exists, create restore.
- If fails then delete the snapshot and restore, and bail.
- If succeeds, goes through usual success flow.
Let's hear from @tiagolobocastro and @dsharma-dc
Member
|
Hey @adam-lithus quick nudge, are you still working on this or intend to? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Huge disclaimer 🚨