build: drop ring feature and dep#156
Merged
Merged
Conversation
Member
|
Whats the difference here? Is it because ring had those license issues flagged on FOSSA? |
Member
|
Also, interesting the rls-aws-lc-rs seems FIPS compliant. |
Member
Author
No, it's help us use FIPS algorithms ; this is not yet there, we'd have to enable fips feature flag, but this is the start |
niladrih
approved these changes
May 11, 2026
Member
Author
|
@mergify queue |
Contributor
Merge Queue Status
This pull request spent 52 seconds in the queue, including 56 seconds running CI. Waiting for
All conditions
ReasonPull request #156 has been dequeued merge conditions no longer match:
HintYou should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
Drops the ring dependency altogether. Ensures kube crates come from workspace so we can specify the actual features on the workspace. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Abhinandan-Purkait
approved these changes
May 11, 2026
Member
Author
|
@mergify queue |
Contributor
Merge Queue Status
This pull request spent 17 seconds in the queue, including 4 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the ring dependency altogether.
Ensures kube crates come from workspace so we can specify the actual features on the workspace.