feat: push events to ephemeral volume if Loki disabled and stdout#879
Open
rohan2794 wants to merge 6 commits into
Open
feat: push events to ephemeral volume if Loki disabled and stdout#879rohan2794 wants to merge 6 commits into
rohan2794 wants to merge 6 commits into
Conversation
af17550 to
fae2ba0
Compare
d97200e to
9fe9421
Compare
69c1ac6 to
67f0095
Compare
tiagolobocastro
left a comment
Member
There was a problem hiding this comment.
Please update the title, we're also pushing to stdout?
Also there are not chores, it's feat
There was a problem hiding this comment.
Pull request overview
This PR extends the events-aggregator to support exporting events to a JSON file on pod-local ephemeral storage when Loki is disabled, and wires the new component into the Nix image build/release flow.
Changes:
- Added a file-based batch exporter with simple rotation and size limiting for event JSON output.
- Switched
events-aggregatorconfiguration toclapCLI parsing (NATS URL, JetStream toggle, Loki toggle, file export options). - Updated Nix packaging and release scripts to build and publish the new
events.aggregatorimage.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/release.sh | Adds events.aggregator to the list of released images. |
| nix/pkgs/images/default.nix | Introduces build-events-image and includes events images in the build set. |
| nix/pkgs/extensions/default.nix | Adds the events extension derivation and installer for events-aggregator. |
| nix/pkgs/extensions/cargo-project.nix | Includes events-aggregator in the all-in-one cargo build set. |
| events-aggregator/src/main.rs | Adds clap-based CLI, exporter wiring, and updates message processing to forward compact JSON to exporter. |
| events-aggregator/src/exporter/mod.rs | Defines exporter module exports for integration with main.rs. |
| events-aggregator/src/exporter/engine.rs | Implements batching, retry loop, disk write, and rotation logic. |
| events-aggregator/src/constant.rs | Centralizes constants for channels, timeouts, batching, and NATS settings. |
| events-aggregator/src/client/nats_client.rs | Refactors to use shared constants and adjusts connection/timeouts and retry logic. |
| events-aggregator/Cargo.toml | Updates dependencies to include clap/url/utils plus exporter dependencies. |
| Cargo.lock | Captures new dependency graph changes (clap/parse-size/tracing-appender/etc). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 5 commits
June 12, 2026 09:06
Signed-off-by: rohan2794 <rohan2794@gmial.com>
Signed-off-by: rohan2794 <rohan2794@gmial.com>
Signed-off-by: rohan2794 <rohan2794@gmial.com>
Signed-off-by: rohan2794 <rohan2794@gmial.com>
…rotation guards Signed-off-by: rohan2794 <rohan2794@gmial.com>
cb1b35e to
690b1f9
Compare
Signed-off-by: rohan2794 <rohan2794@gmial.com>
64e7149 to
4cb2a08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description