fix(nvme): create nvme bdev with spdk_nvme_ctrlr_opts #1932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setup and pass spdk_nvme_ctrlr_opts as a parameter when creating the bdev. This is required because the nvme create bdev function no longer handles a nullptr parameter. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
requested review from
Abhinandan-Purkait and
abhilashshetty04
abhilashshetty04
approved these changes
Dec 3, 2025
Abhinandan-Purkait
approved these changes
Dec 3, 2025
Fixes local build environments. Signed-off-by: Tiago Castro <[email protected]>
Member
Author
|
bors merge |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup and pass spdk_nvme_ctrlr_opts as a parameter when creating the bdev. This is required because the nvme create bdev function no longer handles a nullptr parameter.