Skip to content

fix(nvmf/hosts): handle existing allowed host einval #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors-openebs-mayastor merged 2 commits into from
Dec 4, 2025
Merged

fix(nvmf/hosts): handle existing allowed host einval #1933

bors-openebs-mayastor merged 2 commits into from
Dec 4, 2025

Conversation

@tiagolobocastro
Copy link
Member

@tiagolobocastro tiagolobocastro commented Dec 3, 2025 

refactor(nvmf/hosts): reuse existing connected_hosts

Rather than re-loop the hosts, simply reuse the connected hosts,
and disconnect any which is not on the new allowed list.

fix(nvmf/hosts): handle existing allowed host einval

On the latest spdk, we cannot add the same host back as it's now rejecting
it with einval.
Instead, we check the existing hosts and add only the new ones.

@tiagolobocastro
fix(nvmf/hosts): handle existing allowed host einval
8d11680 
On the latest spdk, we cannot add the same host back as it's now rejecting
it with einval.
Instead, we check the existing hosts and add only the new ones.

Signed-off-by: Tiago Castro <[email protected]>
@tiagolobocastro
refactor(nvmf/hosts): reuse existing connected_hosts
d73a137 
Rather than re-loop the hosts, simply reuse the connected hosts,
and disconnect any which is not on the new allowed list.

Signed-off-by: Tiago Castro <[email protected]>
@tiagolobocastro tiagolobocastro requested a review from a team as a code owner December 3, 2025 13:59
@tiagolobocastro
Copy link
Member Author

tiagolobocastro commented Dec 4, 2025

bors merge

@bors-openebs-mayastor
Copy link

bors-openebs-mayastor bot commented Dec 4, 2025

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit b28c92e into develop Dec 4, 2025
5 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the allowed-hosts branch December 4, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@abhilashshetty04 abhilashshetty04 abhilashshetty04 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiagolobocastro @Abhinandan-Purkait @abhilashshetty04