remove hardcoding of datasource and filter #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhilashshetty04
force-pushed
the
grafana_fix
branch
2 times, most recently
from
e03c336 to
531dad1
Compare
Signed-off-by: Abhilash Shetty <[email protected]>
abhilashshetty04
force-pushed
the
grafana_fix
branch
from
531dad1 to
0ae8053
Compare
Signed-off-by: Dimitris Zervas <[email protected]> Signed-off-by: Abhilash Shetty <[email protected]>
Signed-off-by: krishnaGajabi <[email protected]> Signed-off-by: Abhilash Shetty <[email protected]>
Signed-off-by: krishnaGajabi <[email protected]> Signed-off-by: Abhilash Shetty <[email protected]>
abhilashshetty04
force-pushed
the
grafana_fix
branch
from
01f621f to
1ded285
Compare
niladrih
reviewed
Sep 10, 2025
avishnu
approved these changes
Sep 10, 2025
Member
avishnu
left a comment
avishnu
left a comment
There was a problem hiding this comment.
Since we are updating some of the dependencies here, should this be monitoring 4.2 instead of 4.1.1 ?
niladrih
approved these changes
Sep 10, 2025
Member
|
If there are no new features introduced, IMO it should be okay to make this a patch release. |
avishnu
approved these changes
Sep 10, 2025
Abhinandan-Purkait
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.