lib/nvmf: cherry-pick of stop-for-destroy#79
Merged
Conversation
susobhandey
approved these changes
Jun 10, 2026
susobhandey
left a comment
susobhandey
left a comment
There was a problem hiding this comment.
it is subsystem_stop_for_destroy. straight forward. Looking good
Abhinandan-Purkait
approved these changes
Jun 10, 2026
Replace the bool 'destroying' field with an enum 'nvmf_subsystem_destroy_state'. This prepares for adding additional destroy states (e.g., pending destroy) in subsequent patches. No functional change. Signed-off-by: Jim Harris <jim.harris@nvidia.com> Change-Id: I8eb687271f05877cebafaf8b6623ec4fdabf1711 Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/27717 Reviewed-by: Konrad Sztyber <ksztyber@nvidia.com> Reviewed-by: Jacek Kalwas <jacek.kalwas@nutanix.com> Tested-by: SPDK Automated Test System <spdkbot@gmail.com> Community-CI: Mellanox Build Bot
This stops the subsystem in a way that it cannot be started again, in preparation for destroy. As part of these changes, we can properly handle the case where we get multiple nvmf_subsystem_delete RPCs for the same subsystem, avoiding asserts (which are removed in this patch), or use-after-free errors. Fixes spdk#3801. Signed-off-by: Jim Harris <jim.harris@nvidia.com> Change-Id: Ieffee3da4ccb8e6bd45d726faef323073b2034a6 Reviewed-on: https://review.spdk.io/c/spdk/spdk/+/27600 Tested-by: SPDK Automated Test System <spdkbot@gmail.com> Reviewed-by: Jacek Kalwas <jacek.kalwas@nutanix.com> Community-CI: Mellanox Build Bot Reviewed-by: Konrad Sztyber <ksztyber@nvidia.com>
tiagolobocastro
force-pushed
the
stop-for-destroy
branch
from
e124fe0 to
fc51490
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will simply rebase the commits