build: stop installing upstream unittest/ and test/ into the wheel#22
Merged
Conversation
Their install rules copied test scripts into the wheel platlib as top-level unittest/ and test/ namespace packages, which shadow the Python stdlib modules of the same names under scikit-build-core editable installs (breaks pytest and any import of unittest). Also drop the moot wheel.exclude = ["unnittest"] entry: it was misspelled and never matched, and exclusion now happens at the CMake level.
Anillc
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Their install rules copied test scripts into the wheel platlib as top-level
unittest/andtest/namespace packages, which shadow the Python stdlib modules of the same names under scikit-build-core editable installs (breaks pytest and any import of unittest). Also drop the mootwheel.exclude = ["unnittest"]entry: it was misspelled and never matched, and exclusion now happens at the CMake level.