-
Notifications
You must be signed in to change notification settings - Fork 4.2k
refactor: replace User.objects.create_user for UserFactory p2 #28547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace User.objects.create_user for UserFactory p2 #28547
Conversation
|
Thanks for the pull request, @mariajgrimaldi! I've created OSPR-5990 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
3cd8995 to
f9ead15
Compare
f9ead15 to
56a1cb8
Compare
|
Great work @mariajgrimaldi. |
7fddc02 to
fd5a95d
Compare
|
Given that this is only maintenance It should be fine to merge it with only one CC. However I'll wait till monday morning to not trigger deployments on a Friday evening |
fd5a95d to
cff1886
Compare
This change is done so the profile is automatically created for tests users
cff1886 to
54627e1
Compare
|
Your PR has finished running tests. There were no failures. |
|
Now we are good to merge |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
@mariajgrimaldi @felipemontoya thank you both! |
|
@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This change is done, so the profile is automatically created for tests users. PR continuation of PR 28525
Supporting information
This was discussed -here- after we encountered some errors while using the user's profile in some tests. For example, here:
https://build.testeng.edx.org/job/edx-platform-python-pipeline-pr/33777/
More in detail:
https://build.testeng.edx.org/job/edx-platform-python-pipeline-pr/33777/testReport/junit/cms.djangoapps.contentstore.management.commands.tests.test_create_course/TestCreateCourse/Run_Tests___cms_unit___test_duplicate_course/
Testing instructions
Run edxapp tests:
pytest lms/djangoapps/course_goals/tests/test_goals.py::TestCourseGoalsAPI::test_add_goalpaver test_js_run -s <lms|cms>Deadline
"None"
Other information
This PR just improves tests by adding missing data. This time there are no more references to
User.objects.create_userin tests, just where is required.