Skip to content

Conversation

@mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Aug 25, 2021

This change is done, so the profile is automatically created for tests users. PR continuation of PR 28525

Supporting information

This was discussed -here- after we encountered some errors while using the user's profile in some tests. For example, here:
https://build.testeng.edx.org/job/edx-platform-python-pipeline-pr/33777/
More in detail:
https://build.testeng.edx.org/job/edx-platform-python-pipeline-pr/33777/testReport/junit/cms.djangoapps.contentstore.management.commands.tests.test_create_course/TestCreateCourse/Run_Tests___cms_unit___test_duplicate_course/

Testing instructions

Run edxapp tests:

  1. Run specific tests:
    pytest lms/djangoapps/course_goals/tests/test_goals.py::TestCourseGoalsAPI::test_add_goal
  2. Run specific test suit: paver test_js_run -s <lms|cms>

Deadline

"None"

Other information

This PR just improves tests by adding missing data. This time there are no more references to User.objects.create_user in tests, just where is required.

@openedx-webhooks
Copy link

openedx-webhooks commented Aug 25, 2021

Thanks for the pull request, @mariajgrimaldi! I've created OSPR-5990 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Aug 25, 2021
@mariajgrimaldi mariajgrimaldi changed the title refactor: replace User.objects.create_user for UserFactory refactor: replace User.objects.create_user for UserFactory p2 Aug 25, 2021
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/fix_missing_profile_for_tests branch 6 times, most recently from 3cd8995 to f9ead15 Compare August 26, 2021 00:26
@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review August 26, 2021 00:27
@openedx-webhooks openedx-webhooks added needs triage and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Aug 26, 2021
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/fix_missing_profile_for_tests branch from f9ead15 to 56a1cb8 Compare August 26, 2021 21:14
@felipemontoya
Copy link
Member

Great work @mariajgrimaldi.

@felipemontoya felipemontoya self-requested a review August 26, 2021 21:30
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/fix_missing_profile_for_tests branch 2 times, most recently from 7fddc02 to fd5a95d Compare August 26, 2021 22:22
@felipemontoya
Copy link
Member

Given that this is only maintenance It should be fine to merge it with only one CC. However I'll wait till monday morning to not trigger deployments on a Friday evening

@mariajgrimaldi mariajgrimaldi force-pushed the MJG/fix_missing_profile_for_tests branch from fd5a95d to cff1886 Compare August 30, 2021 12:46
This change is done so the profile is automatically created for tests users
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/fix_missing_profile_for_tests branch from cff1886 to 54627e1 Compare August 30, 2021 15:05
@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@felipemontoya
Copy link
Member

Now we are good to merge

@felipemontoya felipemontoya merged commit 6e48ffd into openedx:master Aug 30, 2021
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@natabene
Copy link
Contributor

natabene commented Sep 2, 2021

@mariajgrimaldi @felipemontoya thank you both!

@openedx-webhooks
Copy link

@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants