-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[BD-32] feat: add 2nd batch of Open edX Events #28640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-32] feat: add 2nd batch of Open edX Events #28640
Conversation
|
Thanks for the pull request, @mariajgrimaldi! I've created BLENDED-953 to keep track of it in Jira. More details are on the BD-32 project page. When this pull request is ready, tag your edX technical lead. |
5a2ea61 to
6166575
Compare
|
Hi there! @ormsbee @feanil @nasthagiri @felipemontoya I hope you're having a great week! I just opened this PR with the second batch of Open edX Events and their tests. I look forward to hearing from you! |
ae13d04 to
560d261
Compare
felipemontoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the events for this PR look good, data is consistent and the same is true for tests. I think we could merge this and thus complete the first 8 basic openedx events.
560d261 to
1150860
Compare
* Add COURSE_ENROLLMENT_CHANGED: sent after the enrollment update * Add COURSE_UNENROLLMENT_COMPLETED: sent after the user's unenrollment * Add CERTIFICATE_CREATED after the user's certificate generation has been completed * Add CERTIFICATE_CHANGED: after the certification update has been completed * Add CERTIFICATE_REVOKED: after the certificate revocation has been completed * Add COHORT_MEMBERSHIP_CHANGED: when a cohort membership update ends
1150860 to
1c447e6
Compare
|
Your PR has finished running tests. There were no failures. |
|
@nasthagiri @ormsbee would you approve us merging this? |
|
Thanks a lot @mariajgrimaldi and @ormsbee. I will merge this now. Open edx events are now in the platform. |
|
@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
1 similar comment
|
EdX Release Notice: This PR has been deployed to the production environment. |
* Add PreEnrollmentFilter * Add PreRegisterFilter * Add PreLoginFilter For more info: openedx/edx-platform#29449 Some events that were already on the platform were also added: * Add COURSE_ENROLLMENT_CHANGED: sent after the enrollment update * Add COURSE_ENROLLMENT_CREATED event after the user's enrollment creation * Add COURSE_UNENROLLMENT_COMPLETED: sent after the user's unenrollment For more info: openedx/edx-platform#28266 openedx/edx-platform#28640
* Add PreEnrollmentFilter * Add PreRegisterFilter * Add PreLoginFilter For more info: openedx/edx-platform#29449 Some events that were already on the platform were also added: * Add COURSE_ENROLLMENT_CHANGED: sent after the enrollment update * Add COURSE_ENROLLMENT_CREATED event after the user's enrollment creation * Add COURSE_UNENROLLMENT_COMPLETED: sent after the user's unenrollment For more info: openedx/edx-platform#28266 openedx/edx-platform#28640

Description
Second batch of Open edX Events, a continuation of #28266. This time around we add the following events:
COURSE_ENROLLMENT_CHANGED: sent after the enrollment updateCOURSE_UNENROLLMENT_COMPLETED: sent after the user's unenrollmentCERTIFICATE_CREATEDafter the user's certificate generation hasbeen completed
CERTIFICATE_CHANGED: after the certification update has beencompleted
CERTIFICATE_REVOKED: after the certificate revocation has been completed.COHORT_MEMBERSHIP_CHANGED: when a cohort membership update endsSupporting information
For an overall understanding of the design, check out the Open edX Events ADRs and discussions:
Discuss on Hooks Extension Framework:
https://discuss.openedx.org/t/configuration-for-the-hooks-extension-framework/4527/
Testing instructions
pip install openedx-events==0.5.1Deadline
Before Maple cut.
Other information
Author's concerns