feat: add first and last name to settings page#1002
Open
syedsajjadkazmii wants to merge 1 commit intosplit-fullnamefrom
Open
feat: add first and last name to settings page#1002syedsajjadkazmii wants to merge 1 commit intosplit-fullnamefrom
syedsajjadkazmii wants to merge 1 commit intosplit-fullnamefrom
Conversation
syedsajjadkazmii
force-pushed
the
sajjad/VAN-1826
branch
3 times, most recently
from
716426b to
13cbebc
Compare
syedsajjadkazmii
force-pushed
the
sajjad/VAN-1826
branch
3 times, most recently
from
a2dce0f to
28d80a7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## split-fullname #1002 +/- ##
==================================================
+ Coverage 56.53% 57.99% +1.46%
==================================================
Files 118 119 +1
Lines 2457 2576 +119
Branches 654 698 +44
==================================================
+ Hits 1389 1494 +105
- Misses 997 1005 +8
- Partials 71 77 +6 ☔ View full report in Codecov by Sentry. |
syedsajjadkazmii
force-pushed
the
sajjad/VAN-1826
branch
from
28d80a7 to
7d9e2fa
Compare
syedsajjadkazmii
force-pushed
the
sajjad/VAN-1826
branch
3 times, most recently
from
e4a806f to
e87d228
Compare
Author
|
There are some missing lines but there are already no tests for those lines so I hope this is okay. For example, sagas don't have tests in this MFE. |
syedsajjadkazmii
force-pushed
the
sajjad/VAN-1826
branch
2 times, most recently
from
ba1c0fb to
0cdd767
Compare
syedsajjadkazmii
force-pushed
the
sajjad/VAN-1826
branch
from
0cdd767 to
d67a252
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits the full name field into first and last name if the
first_nameandlast_namefields are both required in theREGISTRATION_EXTRA_FIELDS.If
first_nameandlast_nameare required in theREGISTRATION_EXTRA_FIELDS, they are passed to the frontend otherwise these are not passed. And on frontend, we have our code behind the check forfirst_nameandlast_name.