refactor: Migration of course details to React query#2724
Conversation
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
… and CourseUpdate
b16ae2c to
6b7f4b5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2724 +/- ##
==========================================
+ Coverage 94.86% 94.89% +0.03%
==========================================
Files 1233 1235 +2
Lines 27940 28254 +314
Branches 6332 6408 +76
==========================================
+ Hits 26505 26813 +308
- Misses 1364 1370 +6
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@bradenmacdonald This is a big one. It's ready for your review. You can review it commit by commit. |
bradenmacdonald
left a comment
There was a problem hiding this comment.
Wow, thanks! This is awesome. I tested various pages and didn't see any new bugs resulting from this. Nice work!
Please consider the following changes before you merge. But let's merge this ASAP.
| courseId: string; | ||
| courseDetails?: CourseDetailsData; | ||
| courseDetailStatus: RequestStatusType; | ||
| canChangeProviders: boolean; |
There was a problem hiding this comment.
What is canChangeProviders ? If you know, can you please add a comment like courseId has? I don't know what this is.
There was a problem hiding this comment.
I'm not entirely sure either; it's used a lot in pages-and-resources/discussions
There was a problem hiding this comment.
Ah, it probably means "can change discussion providers", which would be possible only before the course starts. I don't think it makes sense to have that in the CourseAuthoringContext if it's only about discussions. It should really be something that's decided by the backend, not the frontend, and loaded only when needed to display the discussion settings.
Description
courseDetailspart from the Redux Store to React Query.CourseAuthoringContext<CourseAuthoringRoutes>to use the newly created context.src/testUtils.tsxSupporting information
Testing instructions
<CourseAuthoringRoutes>, and verify that all are rendered successfully.Other information
N/A
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'