Skip to content

refactor: Use formik and yup, and simplify hooks#2993

Open
xitij2000 wants to merge 4 commits into
masterfrom
kshitij/image-css-editor
Open

refactor: Use formik and yup, and simplify hooks#2993
xitij2000 wants to merge 4 commits into
masterfrom
kshitij/image-css-editor

Conversation

@xitij2000

@xitij2000 xitij2000 commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Description

This change converts the Image Editor Modal to TypeScript and simplifies the hooks switching to Formik + Yup for form validation.

It updates the tests to check the behaviour of the component as a whole rather than testing small components.

This lays the groundwork for the CSS editor work.

Supporting information

Testing instructions

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Apr 10, 2026
@openedx-webhooks

openedx-webhooks commented Apr 10, 2026

Copy link
Copy Markdown

Thanks for the pull request, @xitij2000!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Apr 10, 2026
@xitij2000 xitij2000 force-pushed the kshitij/image-css-editor branch 2 times, most recently from 146be13 to ab0d327 Compare April 11, 2026 07:52
isOpen={isConfirmOpen}
close={() => { setConfirmOpen(false); }}
title={<FormattedMessage {...messages[`ConfirmSwitchMessageTitle-${editorType}`]} />}
title={intl.formatMessage(messages[`ConfirmSwitchMessageTitle-${editorType}`])}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed because title is only supposed to be a string and not a ReactNode.

@xitij2000 xitij2000 force-pushed the kshitij/image-css-editor branch 2 times, most recently from 488b887 to ad087a0 Compare April 13, 2026 09:44
@codecov

codecov Bot commented Apr 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.64%. Comparing base (b0efcd6) to head (b585ea5).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2993      +/-   ##
==========================================
+ Coverage   95.62%   95.64%   +0.01%     
==========================================
  Files        1392     1409      +17     
  Lines       33131    33363     +232     
  Branches     7707     7581     -126     
==========================================
+ Hits        31681    31909     +228     
- Misses       1385     1404      +19     
+ Partials       65       50      -15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 16, 2026
@xitij2000 xitij2000 force-pushed the kshitij/image-css-editor branch 3 times, most recently from 33eecdf to 29f878e Compare May 8, 2026 19:31
@xitij2000 xitij2000 marked this pull request as ready for review May 8, 2026 19:33
@xitij2000 xitij2000 force-pushed the kshitij/image-css-editor branch from 29f878e to ae493ea Compare May 8, 2026 19:36
@xitij2000 xitij2000 force-pushed the kshitij/image-css-editor branch from ae493ea to cb5c05d Compare May 8, 2026 19:44

@farhaanbukhsh farhaanbukhsh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xitij2000 Functionality looks good I have few suggestions though!

Comment thread src/editors/sharedComponents/ImageUploadModal/ImageSettingsModal/index.test.tsx Outdated
This commit is mainly to get git to reconise the rename so file history is
maintained.
This change converts the Image Editor Modal to typescript and simplifies the hooks switching to Formik + Yup for form validation.

It updates the tests to check the behaviour of the component as a whole rather than testing small components.
@xitij2000 xitij2000 force-pushed the kshitij/image-css-editor branch from 7a4e4b8 to 8fa86a0 Compare June 15, 2026 09:53
@xitij2000 xitij2000 force-pushed the kshitij/image-css-editor branch from 8fa86a0 to b585ea5 Compare June 16, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

4 participants