feat: remove the legacy library viewing and editing page by salman2013 · Pull Request #3080 · openedx/frontend-app-authoring

salman2013 · 2026-06-04T09:55:29Z

Description

Removes the legacy library (V1) tab, routes, and associated UI from Studio Home. The migration wizard (/libraries-v1/migrate) is preserved to allow users to migrate existing legacy library content to V2.

Testing instructions

** Legacy Library Tab should not show on the studio home page**
** Library Tab (Library v2) should work properly:**

Log in to Studio and navigate to the Studio Home (/home).
Confirm the Libraries tab is visible and clicking it navigates to /libraries.
Click New Library — confirm it opens the V2 library creation page.
Create or open an existing V2 library and confirm normal editing works.

Legacy routes are removed:

Navigate directly to /libraries-v1 — confirm it returns a 404 / "not found" page.
Navigate directly to /libraries-v1/create — confirm it also returns a 404 / "not found" page.
Confirm there is no legacy Libraries tab on Studio Home.

Migration wizard exit navigates correctly:

Navigate to the migration wizard at /libraries-v1/migrate for a legacy library.
Click Exit — confirm you are redirected to /libraries (V2 libraries list), not /libraries-v1.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

Any new files are using TypeScript (.ts, .tsx). (N/A — no new files added)
Avoid propTypes and defaultProps in any new or modified code. (N/A — no new props introduced)
Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks) (N/A — existing tests updated, no new test files)
Do not add new fields to the Redux state/store. Use React Context to share state among multiple components. (N/A — Redux state only reduced, nothing added)
Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples. (N/A — no new API calls)
All new i18n messages in messages.ts files have a description for translators to use. (N/A — no new i18n messages)
Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils' (N/A — no new imports added)

Settings

EDX_PLATFORM_REPOSITORY: https://github.com/openedx/openedx-platform.git
EDX_PLATFORM_VERSION: master

openedx-webhooks · 2026-06-04T09:55:35Z

Thanks for the pull request, @salman2013!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2026-06-04T10:40:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.55%. Comparing base (3f531d5) to head (15b1d87).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3080      +/-   ##
==========================================
- Coverage   95.61%   95.55%   -0.07%     
==========================================
  Files        1391     1391              
  Lines       33075    33057      -18     
  Branches     7680     7667      -13     
==========================================
- Hits        31626    31588      -38     
- Misses       1384     1401      +17     
- Partials       65       68       +3

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Removes the legacy library (V1) tab, routes, and associated UI from Studio Home. The migration wizard (/libraries-v1/migrate) is preserved to allow users to migrate existing legacy library content to V2. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

The /libraries-v1 route was removed when the legacy library viewing and editing page was removed. The migration wizard exit button was still navigating to that removed route, causing a 404 error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR removes the legacy (v1) libraries experience from Studio Home, leaving only the v2 libraries tab and v2 library creation flow, and updates navigation/tests accordingly.

Changes:

Removed the legacy libraries tab, route handling, and related props/state.
Updated migration exit navigation to return to the v2 libraries area.
Simplified/updated tests to reflect the removal of v1 libraries UI and routes.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/studio-home/tabs-section/index.tsx	Removes legacy libraries tab/state and simplifies tab routing to v2 libraries only.
src/studio-home/tabs-section/TabsSection.test.tsx	Deletes legacy libraries tests and updates navigation expectations to `/libraries`.
src/studio-home/hooks.tsx	Stops exposing `librariesV1Enabled` from the studio home hook.
src/studio-home/StudioHome.tsx	Removes v1 library button logic and always navigates to v2 create page.
src/studio-home/StudioHome.test.tsx	Removes tests covering v1-only/v2-only button behavior and legacy create navigation.
src/legacy-libraries-migration/LegacyLibMigrationPage.tsx	Changes “Exit” navigation target from `/libraries-v1` to `/libraries`.
src/legacy-libraries-migration/LegacyLibMigrationPage.test.tsx	Updates expectation for exit navigation to `/libraries`.
src/index.jsx	Removes `/libraries-v1` and `/libraries-v1/create` routes and legacy create import.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

salman2013 · 2026-06-11T09:54:57Z

        <Route path="/home" element={<StudioHome />} />
        <Route path="/libraries" element={<StudioHome />} />
-        <Route path="/libraries-v1" element={<StudioHome />} />
+
        <Route path="/libraries-v1/migrate" element={<LegacyLibMigrationPage />} />
-        <Route path="/libraries-v1/create" element={<CreateLegacyLibrary />} />
        <Route path="/library/create" element={<CreateLibrary />} />


Good suggestion but i believe that as we already deprecated the legacy library with warnings, so now this edge case does not need to fix.

- Inline librariesV2Enabled directly instead of showV2LibraryURL alias - Fall back to courses tab in initTabKeyState when librariesV2Enabled is false, preventing blank tab when /libraries is visited with libraries disabled - Add test for librariesV2Enabled: false to prevent regressions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

irfanuddinahmad · 2026-06-10T07:28:07Z

@@ -9,7 +9,6 @@ import { getConfig } from '@edx/frontend-platform';
 import { useIntl } from '@edx/frontend-platform/i18n';


The import of BaseFilterState, Filter, and LibrariesList from ./libraries-tab is removed here, but the libraries-tab directory itself does not appear to be deleted in this PR. If nothing else imports from it, this is now dead code. Worth either deleting the directory in this PR or filing a follow-up to keep the codebase clean.

The libraries-tab directory is still actively used — LegacyLibMigrationPage.tsx imports Filter and LibrariesList from it for the migration
wizard (/libraries-v1/migrate route), which we intentionally preserved. It will be cleaned up in a future PR when the migration wizard itself
is removed (after the platform-side V1 removal tracked in openedx/openedx-platform#38057).

irfanuddinahmad · 2026-06-10T07:28:24Z

@@ -75,9 +74,8 @@ const App = () => {
      <Route>
        <Route path="/home" element={<StudioHome />} />


Nit: a stray blank line was left where the /libraries-v1 route was removed. Worth cleaning up for readability.

blank line has removed.

irfanuddinahmad · 2026-06-10T07:28:39Z

Two template housekeeping items:

Testing instructions are empty — the "## Testing instructions" section has no content. Given the scope of what changed (tab removed, routes removed, exit navigation updated), reviewers need guidance on how to verify the happy path (V2 tab still works, migration flow still exits correctly) and the removed paths (legacy tab is gone, old routes 404 or redirect).

Best Practices Checklist is unchecked — all boxes are [ ]. Even if everything is N/A for a deletion PR, it is worth a quick pass so reviewers know the checklist was considered.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

salman2013 · 2026-06-11T10:14:33Z

@kdmccormick, @feanil Just a question should we also remove the migrate legacy library page in this scope? This page appears from the legacy library tab, which has been removed in this PR, so there is no way to access it other than manually typing the URL.

Migrate legacy library

The Migrate legacy library page access from the legacy library tab, which has been removed in this PR.

This reverts commit 7e05210.

feanil · 2026-06-11T18:37:53Z

I think it makes sense to remove the migrate legacy library page if it was only reachable from here.

openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 4, 2026

openedx-webhooks added this to Contributions Jun 4, 2026

github-project-automation Bot moved this to Needs Triage in Contributions Jun 4, 2026

salman2013 force-pushed the salman/remove-legacy-library-edit-page branch from debb76c to dfebf78 Compare June 4, 2026 10:41

salman2013 mentioned this pull request Jun 4, 2026

[willow] Legacy Libraries DEPR: Remove create/edit/view/config support openedx/openedx-platform#38056

Open

6 tasks

salman2013 marked this pull request as ready for review June 4, 2026 10:53

irfanuddinahmad requested a review from Copilot June 4, 2026 11:14

Copilot AI reviewed Jun 4, 2026

View reviewed changes

mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Jun 4, 2026

irfanuddinahmad reviewed Jun 10, 2026

View reviewed changes

salman2013 added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Jun 10, 2026

style: remove stray blank line in router config

7e05210

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

salman2013 closed this Jun 11, 2026

github-project-automation Bot moved this from Waiting on Author to Done in Contributions Jun 11, 2026

salman2013 reopened this Jun 11, 2026

salman2013 closed this Jun 11, 2026

salman2013 reopened this Jun 11, 2026

Revert "style: remove stray blank line in router config"

8381aad

This reverts commit 7e05210.

		@@ -9,7 +9,6 @@ import { getConfig } from '@edx/frontend-platform';
		import { useIntl } from '@edx/frontend-platform/i18n';

		@@ -75,9 +74,8 @@ const App = () => {
		<Route>
		<Route path="/home" element={<StudioHome />} />

Conversation

salman2013 commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Best Practices Checklist

Settings

Uh oh!

openedx-webhooks commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

salman2013 Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

irfanuddinahmad Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

salman2013 Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

irfanuddinahmad Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

salman2013 Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

irfanuddinahmad commented Jun 10, 2026

Uh oh!

salman2013 commented Jun 11, 2026

Uh oh!

feanil commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

salman2013 commented Jun 4, 2026 •

edited

Loading

openedx-webhooks commented Jun 4, 2026 •

edited

Loading

codecov Bot commented Jun 4, 2026 •

edited

Loading