Skip to content

fix: add npm override for axios (CVE-2025-58754)#3098

Open
jignaciopm wants to merge 1 commit into
openedx:release/ulmofrom
eduNEXT:jipm/fix-synack-W1162-7-axios-ulmo
Open

fix: add npm override for axios (CVE-2025-58754)#3098
jignaciopm wants to merge 1 commit into
openedx:release/ulmofrom
eduNEXT:jipm/fix-synack-W1162-7-axios-ulmo

Conversation

@jignaciopm

Copy link
Copy Markdown
Contributor

Summary

Add npm overrides for axios to address CVE-2025-58754 (Denial of Service via massive data schemas in Node.js).

CVSS: 7.5 (High)

Why npm overrides instead of bumping frontend-platform?

The vulnerable axios version (1.9.0) is a transitive dependency of @edx/frontend-platform. The fix was shipped in frontend-platform v8.5.5+ (axios ≥1.13.5), but this MFE's release branch pins frontend-platform ^8.3.1.

Bumping frontend-platform from 8.3.x to 8.5.x on a frozen release branch carries risk of breaking changes that were not tested against this release. The npm overrides mechanism is the standard npm approach to force a transitive dependency to a safe version without changing the parent package version.

Note: release/verawood already ships with frontend-platform ^8.7.0 (axios 1.15.0) and is not affected by this vulnerability.

frontend-platform → axios version timeline

frontend-platform axios Status
8.3.1 1.8.2 Safe
8.4.0 – 8.5.0 1.9.0 Vulnerable (CVE-2025-58754)
8.5.5 1.13.5 Fixed
8.5.6+ 1.15.0 Fixed

Change

"overrides": {
  "axios": "^1.9.1"
}

This forces npm to resolve axios to ≥1.9.1 across the entire dependency tree, including the copy bundled by @edx/frontend-platform.

Test plan

  • MFE builds successfully with the override
  • Verify resolved axios version in node_modules is ≥1.9.1
  • Smoke test core MFE functionality

References

Axios versions prior to 1.9.1 are vulnerable to Denial of Service via
massive data schemas (CVE-2025-58754). The vulnerable version is pulled
as a transitive dependency from @edx/frontend-platform.

Adding an npm override forces resolution to a patched version without
changing the frontend-platform version, avoiding breaking changes.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 16, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @jignaciopm!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@bradenmacdonald

Copy link
Copy Markdown
Contributor

Thanks @jignaciopm. Could you please update the package-lock file as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

3 participants