Skip to content

Fix: Updated sign out to logout for consistency #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

zubairshakoorarbisoft
Copy link

📄 Description

This PR resolves consistency of Inconsistent navigation across "Profile," "Account," and "Dashboard" pages.

🎯 Issue

Actual Result:
The "Profile," "Account," and "Dashboard" pages have different navigation lists, leading to inconsistency in the user experience. This inconsistency can confuse users and make navigation between pages less intuitive.
image

✅ Fix

Need to update the word from Sign Out to Logout for consistency among all the pages.

🔗 Related

Live Preview: Demo Course – Progress
Taiga Ticket: Inconsistent navigation across "Profile," "Account," and "Dashboard" pages
Related GitHub Issue: overhangio/tutor-indigo#146

MaxFrank13
MaxFrank13 previously approved these changes May 20, 2025
@MaxFrank13 MaxFrank13 dismissed their stale review May 20, 2025 01:08

Missed a failing test

Copy link
Member

@MaxFrank13 MaxFrank13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Although it looks like we'll need to update the snapshot for this component's test. Can you run npm test -- -u to see if that fixes it?

@MaxFrank13 MaxFrank13 moved this to In Progress in Aperture-Maintained May 22, 2025
@MaxFrank13 MaxFrank13 added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants