Skip to content

Deprecate react-unit-test-utils 1/15 #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

diana-villalvazo-wgu
Copy link
Contributor

@diana-villalvazo-wgu diana-villalvazo-wgu commented Jun 9, 2025

Description

Remove use of 'shallow' (react-unit-test-utils) in following files, when needed we also removed snapshot to create new unit tests:

  • src/components/NoticesWrapper/index.test.jsx
  • src/components/Banner.test.jsx
  • src/containers/CourseCard/components/CourseCardActions/ActionButton/index.test.jsx
  • src/containers/CourseCard/components/CourseCardActions/BeginCourseButton.test.jsx
  • src/containers/CourseCard/components/CourseCardActions/ResumeButton.test.jsx

Note: As part of this work we find out paragon components were mocked on src/setupTest.jsx causing testing library unit tests to fail, since we are doing this work in multiple PRs and in order to not break other existing snapshot tests, we will unmock paragon or needed things on new tests and by end of react-unit-test-utils removal we will remove paragon mocks and unmock lines accordingly.

Support Information

Closes #637

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 9, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 9, 2025

Thanks for the pull request, @diana-villalvazo-wgu!

This repository is currently maintained by @2U-aperture.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (c4205e9) to head (0106e0e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #640   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files         152      152           
  Lines        1332     1332           
  Branches      229      230    +1     
=======================================
  Hits         1299     1299           
  Misses         32       32           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@diana-villalvazo-wgu diana-villalvazo-wgu added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Jun 9, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu marked this pull request as ready for review June 9, 2025 19:33
@diana-villalvazo-wgu diana-villalvazo-wgu requested a review from a team as a code owner June 9, 2025 19:33
Copy link
Contributor

@vmnavarro94 vmnavarro94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@diana-villalvazo-wgu diana-villalvazo-wgu moved this from Needs Triage to Ready for Review in Contributions Jun 11, 2025
@arbrandes arbrandes self-requested a review June 11, 2025 19:19
@diana-villalvazo-wgu
Copy link
Contributor Author

Hi @openedx/2u-aperture can someone help with a review? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U
Projects
Status: No status
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

Deprecate react-unit-test-utils 1/15
3 participants