[DRAFT] feat: add support to paragon design tokens#1203
[DRAFT] feat: add support to paragon design tokens#1203ghassanmas wants to merge 1 commit intoopenedx:masterfrom
Conversation
This PR purpose is to test/demo parago design tokens simliar to this one for the profile openedx/frontend-app-profile/pull/764 it override the following depns as seen in package.json - paragon alpha - openedx/frontend-build/pull/365 - openedx/frontend-platform/pull/440 - openedx/frontend-component-header/pull/351 - openedx/frontend-component-footer/pull/303 Conclousion so far: - There is an extra library that learning depends on which needs to support paragon; `frontend-lib-learning-assistant` and also `frontend-lib-special-exams` - It would be great to have a gudie or a document to look at, while doing the conversion that would **map variable from who it was used/named before to the name in design tokens** - I was stuck in the end with compliation error, that wepack couldn't find `Modal` exported from paragon.
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
itsjeyd
added
waiting on author
|
Thank you for this contribution @ghassanmas! Let us know when the changes are ready for review. |
|
Hi @ghassanmas! Just a quick update that we're closing this PR for now because it seems to be stale. You can of course reopen this pull request, or open a new one, when you have time to come back to this work. |
|
@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
1 similar comment
|
@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
itsjeyd
added
closed inactivity
|
@itsjeyd this was for demonstration just like this openedx/frontend-app-profile#764 |
3 participants
This PR purpose is to test/demo parago design tokens simliar
to this one for the profile openedx/frontend-app-profile/pull/764
it override the following depns as seen in package.json
PARAGONas a global variable frontend-build#365Conclousion so far:
There is an extra library that learning depends on which needs to support paragon;
frontend-lib-learning-assistantand alsofrontend-lib-special-examsIt would be great to have a gudie or a document to look at, while doing the conversion that would map variable from who it was used/named before to the name in design tokens
I was stuck in the end with compliation error, that wepack couldn't find
Modalexported from paragon.