feat: updated event signal metadata time #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robrap
force-pushed
the
robrap/add-time-and-fix-metadata
branch
2 times, most recently
from
606d5a7 to
eaca0f6
Compare
rgraber
reviewed
Jan 19, 2023
Contributor
rgraber
left a comment
rgraber
left a comment
There was a problem hiding this comment.
One more thought about defaults
robrap
changed the title
robrap
commented
Jan 20, 2023
robrap
commented
Jan 20, 2023
rgraber
approved these changes
Jan 23, 2023
Contributor
rgraber
left a comment
rgraber
left a comment
There was a problem hiding this comment.
LGTM, thanks for the updates
* Updated time metadata to include UTC timezone. Original implementation used utcnow(), which could give different results if the time were ever interpreted to be local time. See https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow * Updated send_event to optionally take a time, which would be used for the metadata. Ideally, this will be explicitly set. #162
robrap
force-pushed
the
robrap/add-time-and-fix-metadata
branch
from
04d9e2e to
52d6efc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
interpreted to be local time. See https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow
ISSUE:
send_event_in_bus_consumer, which will require an additional breaking change to EventsMetadata. That will likely be made in a separate branch and merged into this PR.Testing instructions:
Merge checklist:
Version bumpedPost merge:
Create a tagCheck new version is pushed to PyPI after tag-triggered build isfinished.
Author concerns:
I don't love how EventsMetadata is initialized with time that can be None, but this is how I think it needs to be done for the frozen attributes. Note, this pattern is going to be followed in the follow-up PR where all arguments need to be sent for event bus consumers.Note: We found a way around this. :)