Skip to content

Conversation

@mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Aug 23, 2021

Description:
This PR adds classes and methods that allow developers to enable/disable events during testing. This implementation is a result of this discussion

Testing instructions:

  1. make lms-shell
  2. pip install git+https://github.com/eduNEXT/openedx-events@MJG/isolate_signal_sending#egg=openedx-events==0.5.0_alpha
  3. Go to openedx/core/djangoapps/user_api/tests/test_views.py L31
  4. In UserAPITestCase add the mixin OpenEdxEventsTestCase
  5. Execute tests, for example: pytest openedx/core/djangoapps/user_authn/views/tests/test_register.py::RegistrationValidationViewTests
  6. Manually check that the signal is not sent

Reviewers:

  • tag reviewer
  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@mariajgrimaldi mariajgrimaldi force-pushed the MJG/isolate_signal_sending branch 5 times, most recently from 0b55c7c to ae3d6e5 Compare August 24, 2021 17:47
@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review August 24, 2021 17:47
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/isolate_signal_sending branch from 4adacd3 to 497d091 Compare August 24, 2021 17:57
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once QA passes and the OpenEdxEventsTestCase docstring is complete I think we are ready to merge this.

@mariajgrimaldi mariajgrimaldi force-pushed the MJG/isolate_signal_sending branch 3 times, most recently from 20918d9 to 0b6f5ba Compare August 24, 2021 19:54
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/isolate_signal_sending branch from 0b6f5ba to a267869 Compare August 24, 2021 20:57
@mariajgrimaldi mariajgrimaldi merged commit 6dd0af9 into main Aug 24, 2021
@mariajgrimaldi mariajgrimaldi deleted the MJG/isolate_signal_sending branch August 31, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants