Skip to content

Conversation

@BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Jul 1, 2025

Description

This PR removes some signals from unserializable list according to the added support for complex types in this PR.

Supporting information

Deadline

None

Checklists

Check off if complete or not applicable:

Merge Checklist:

  • All reviewers approved
  • Reviewer tested the code following the testing instructions
  • CI build is green
  • Version bumped
  • Changelog record added with short description of the change and current date
  • Documentation updated (not only docstrings)
  • Integration with other services reviewed
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post Merge:

  • Create a tag
  • Create a release on GitHub
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)
  • Upgrade the package in the Open edX platform requirements (if applicable)

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 1, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 1, 2025

Thanks for the pull request, @BryanttV!

This repository is currently maintained by @openedx/committers-openedx-events.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Jul 1, 2025
@BryanttV BryanttV force-pushed the bav/remove-signals-from-unserializable-list branch from 2cba08f to 1ca75ea Compare July 8, 2025 18:54
@BryanttV BryanttV marked this pull request as ready for review July 8, 2025 18:54
@BryanttV BryanttV requested a review from a team July 8, 2025 18:54
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jul 15, 2025
@mphilbrick211
Copy link

Hi @BryanttV! Is this pull request still in progress?

@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Sep 16, 2025
@mphilbrick211 mphilbrick211 added inactive PR author has been unresponsive for several months and removed core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Sep 16, 2025
@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Sep 16, 2025
@BryanttV BryanttV force-pushed the bav/remove-signals-from-unserializable-list branch from 1ca75ea to bb5815b Compare September 30, 2025 02:00
@BryanttV
Copy link
Contributor Author

Hi @mphilbrick211. This PR is ready, but it needs to be merged after this PR (#483)

@mphilbrick211 mphilbrick211 moved this from Ready for Review to Blocked in Contributions Nov 6, 2025
@BryanttV BryanttV force-pushed the bav/remove-signals-from-unserializable-list branch from bb5815b to a0dd7ae Compare November 26, 2025 19:55
@BryanttV BryanttV force-pushed the bav/remove-signals-from-unserializable-list branch from a0dd7ae to 4618021 Compare December 1, 2025 16:41
@BryanttV
Copy link
Contributor Author

BryanttV commented Dec 1, 2025

Hi @mariajgrimaldi. I just updated this PR, including a new 10.6.0 release.

@mphilbrick211 mphilbrick211 removed the inactive PR author has been unresponsive for several months label Dec 19, 2025
@mphilbrick211 mphilbrick211 moved this from Blocked to Ready for Review in Contributions Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

3 participants