Skip to content

chore: remove registration extension form setting#38637

Open
BryanttV wants to merge 11 commits into
openedx:masterfrom
eduNEXT:bav/remove-registration-extension-form-setting
Open

chore: remove registration extension form setting#38637
BryanttV wants to merge 11 commits into
openedx:masterfrom
eduNEXT:bav/remove-registration-extension-form-setting

Conversation

@BryanttV
Copy link
Copy Markdown
Contributor

@BryanttV BryanttV commented May 12, 2026

Description

This PR removes the deprecated REGISTRATION_EXTENSION_FORM setting and consolidates profile extension functionality under the PROFILE_EXTENSION_FORM setting. This change is part of the Drop REGISTRATION_EXTENSION_FORM Deprecation ticket.

Changes

Core Changes

  • Removed REGISTRATION_EXTENSION_FORM setting: Deprecated setting has been removed from the codebase.
  • Consolidated to PROFILE_EXTENSION_FORM: All profile extension functionality now uses a single, consistent setting.
  • Renamed functions for clarity: Updated function names from "registration extension" to "profile extension" terminology to better reflect their purpose.

Test Updates

  • Fixed test patching: Updated test decorators to patch get_profile_extension_model instead of the non-existent get_extended_profile_model
  • Renamed test references: Updated all test references from "registration extension form" to "profile extension form"
  • Improved test coverage: Enhanced tests for extended profile handling and validation

Breaking Changes

⚠️ Important: Sites using REGISTRATION_EXTENSION_FORM must migrate to PROFILE_EXTENSION_FORM

Supporting information

Testing instructions

You can follow the instructions in this PR

Deadline

None

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels May 12, 2026
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented May 12, 2026

Thanks for the pull request, @BryanttV!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions May 12, 2026
@BryanttV BryanttV marked this pull request as ready for review May 12, 2026 22:37
@BryanttV BryanttV requested review from a team as code owners May 12, 2026 22:37
@BryanttV BryanttV force-pushed the bav/remove-registration-extension-form-setting branch from 32a5e6d to e9fe9e1 Compare May 13, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants