Refactor database engine usage in import functions #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joda9
force-pushed
the
new_engine_handling
branch
from
f18794f to
198b77f
Compare
- Removed the `engine` parameter from various functions in the `oedb` imports for generators, heat pumps, storage, and timeseries. - Updated internal function calls to use `edisgo_object.engine` instead of passing the engine as a parameter. - Adjusted related tests to reflect these changes, ensuring that the `engine` parameter is no longer required. - Improved code consistency and readability by centralizing the engine access through the `EDisGo` object.
joda9
force-pushed
the
new_engine_handling
branch
from
198b77f to
5a8df7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the usage of the database engine in import functions to improve code consistency and readability. Remove the
engineparameter from various functions, centralizing engine access through theEDisGoobject. Update related tests and documentation accordingly.